Feat/OFAC list #499
Feat/OFAC list #499
Conversation
WalkthroughThe changes include the introduction of functionality for fetching and storing a list of Ethereum wallets from a specified URL to enhance compliance with OFAC regulations. A new script has been added to the build process to execute this fetching operation. Modifications have been made to various files to integrate checks against the OFAC list, ensuring that transactions involving restricted addresses are not processed. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Build Script
participant OFAC Fetch Script
participant MsgBroadcaster
User->>Build Script: Initiate Build
Build Script->>OFAC Fetch Script: Run fetch:ofac
OFAC Fetch Script-->>Build Script: Fetch Completed
Build Script->>MsgBroadcaster: Proceed with Build
MsgBroadcaster->>OFAC JSON: Check Ethereum Address
OFAC JSON-->>MsgBroadcaster: Address Status
MsgBroadcaster->>User: Transaction Processed or Blocked
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range, codebase verification and nitpick comments (1)
packages/exceptions/src/types/modules.ts (1)
24-24: Integration of new error category needed.The
Permissionsentry in theChainErrorModuleenum is currently not used in the codebase beyond its definition. Please ensure that this new error category is integrated into the error handling mechanisms throughout the application to fully utilize its addition.Analysis chain
Approve addition and suggest integration check.
The addition of the
Permissionsentry to theChainErrorModuleenum is appropriate. Ensure that this new error category is properly integrated with the error handling mechanisms throughout the application.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new error category is used in error handling. # Test: Search for the new error category usage. Expect: At least one occurrence. rg --type typescript 'chain-permissions'Length of output: 75
Script:
#!/bin/bash # Description: Verify that the new error category is used in error handling. # Test: Search for the new error category usage. Expect: At least one occurrence. rg --type ts 'chain-permissions'Length of output: 109
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (22)
- etc/ofac.js (1 hunks)
- packages/exceptions/src/types/modules.ts (1 hunks)
- packages/sdk-ts/src/client/chain/grpc/ChainGrpcPermissionsApi.spec.ts (5 hunks)
- packages/sdk-ts/src/client/chain/grpc/ChainGrpcPermissionsApi.ts (7 hunks)
- packages/sdk-ts/src/client/chain/transformers/ChainGrpcPermissionsTransformer.ts (1 hunks)
- packages/sdk-ts/src/client/chain/types/permissions.ts (1 hunks)
- packages/sdk-ts/src/core/modules/permissions/index.ts (1 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgClaimVoucher.ts (4 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgCreateNamespace.spec.ts (1 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgCreateNamespace.ts (2 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgDeleteNamespace.spec.ts (1 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgDeleteNamespace.ts (2 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgRevokeNamespaceRoles.spec.ts (2 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgRevokeNamespaceRoles.ts (3 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespace.spec.ts (2 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespace.ts (3 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespaceRoles.spec.ts (1 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespaceRoles.ts (3 hunks)
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateParams.ts (2 hunks)
- packages/wallet-ts/package.json (1 hunks)
- packages/wallet-ts/src/broadcaster/MsgBroadcaster.ts (5 hunks)
- packages/wallet-ts/src/json/ofac.json (1 hunks)
Files skipped from review due to trivial changes (17)
- packages/sdk-ts/src/client/chain/grpc/ChainGrpcPermissionsApi.spec.ts
- packages/sdk-ts/src/client/chain/grpc/ChainGrpcPermissionsApi.ts
- packages/sdk-ts/src/client/chain/transformers/ChainGrpcPermissionsTransformer.ts
- packages/sdk-ts/src/core/modules/permissions/index.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgClaimVoucher.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgCreateNamespace.spec.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgCreateNamespace.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgDeleteNamespace.spec.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgDeleteNamespace.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgRevokeNamespaceRoles.spec.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgRevokeNamespaceRoles.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespace.spec.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespace.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespaceRoles.spec.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateNamespaceRoles.ts
- packages/sdk-ts/src/core/modules/permissions/msgs/MsgUpdateParams.ts
- packages/wallet-ts/src/json/ofac.json
Additional comments not posted (4)
packages/sdk-ts/src/client/chain/types/permissions.ts (1)
1-56: Approve changes and suggest consistency check.The updates to the type definitions align with the PR objectives and enhance clarity. Ensure that these changes are consistently applied across the application to avoid integration issues.
Verification successful
Verification successful: New type definitions are consistently used.
The transition to the new type definitions has been successfully implemented, with no occurrences of the old type found. The new type
InjectivePermissionsV1Beta1Permissionsis consistently used across the codebase, aligning with the PR objectives. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new type definitions are consistently used across the application. # Test: Search for the old type usage. Expect: No occurrences. rg --type typescript 'InjectivePermissionsV1Beta1Exchange'Length of output: 93
Script:
#!/bin/bash # Description: Verify the usage of new and old type definitions across the application. # Find all TypeScript files and search for old type definitions. fd --extension ts --exec rg 'InjectivePermissionsV1Beta1Exchange' {} # Find all TypeScript files and search for new type definitions. fd --extension ts --exec rg 'InjectivePermissionsV1Beta1Permissions' {}Length of output: 523
packages/wallet-ts/package.json (2)
25-25: Review the modifiedbuildscript.The
buildscript has been updated to include thefetch:ofacoperation before proceeding with the existing build steps. This ensures that the OFAC data fetching is completed prior to the build, which is crucial for compliance. The use ofyarnto chain these commands is appropriate and ensures that each step must complete successfully before the next begins.
22-22: Review thefetch:ofacscript addition.The addition of the
fetch:ofacscript is crucial for ensuring compliance with OFAC regulations. The script uses the--experimental-fetchflag, which enables experimental fetch capabilities in Node.js. This is appropriate for making network requests directly from a Node.js script. However, ensure that the relative path./../../etc/ofac.jscorrectly points to the intended script file.Verification successful
Path to
ofac.jsis correct.The relative path
./../../etc/ofac.jsspecified in thefetch:ofacscript correctly points to the intended script file. The file exists at the specified location.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the ofac.js script at the specified path. fd --type file --full-path 'etc/ofac.js'Length of output: 52
packages/wallet-ts/src/broadcaster/MsgBroadcaster.ts (1)
61-61: Review the import of the OFAC JSON data.The import of
ofac.jsonintroduces external compliance data into the transaction processing logic. Ensure that the relative path./../json/ofac.jsoncorrectly points to the JSON file containing the OFAC list. This is crucial for the functionality to work as expected.Verification successful
Import path for OFAC JSON data is correct.
The
ofac.jsonfile exists at the specified path, and the import path inMsgBroadcaster.tsis correct. The functionality should work as expected.
- File:
packages/wallet-ts/src/json/ofac.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the existence of the ofac.json file at the specified path. fd --type file --full-path 'src/json/ofac.json'Length of output: 85
| const storeJsonFile = (path, data) => { | ||
| const dirPath = dirname(path) | ||
|
|
||
| if (!existsSync(dirPath)) { | ||
| try { | ||
| mkdirSync(dirPath, { recursive: true }) | ||
| } catch (e) { | ||
| console.log('❌❌❌ Error creating directory', e) | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| writeFileSync(path, data) | ||
| } catch (e) { | ||
| console.error(`❌❌❌ Error creating JSON file: ${path}`, e) | ||
| } | ||
| } |
There was a problem hiding this comment.
Enhance data handling and error messages in storeJsonFile.
The function should ensure that data is properly formatted as JSON before writing. Additionally, the error messages could be more descriptive to aid in debugging. Consider these changes:
- writeFileSync(path, data)
+ writeFileSync(path, JSON.stringify(data, null, 2)) // Adds indentation for readability
- console.log('❌❌❌ Error creating directory', e)
+ console.error('Error creating directory at path:', dirPath, e)
- console.error(`❌❌❌ Error creating JSON file: ${path}`, e)
+ console.error('Error writing to JSON file at path:', path, e)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const storeJsonFile = (path, data) => { | |
| const dirPath = dirname(path) | |
| if (!existsSync(dirPath)) { | |
| try { | |
| mkdirSync(dirPath, { recursive: true }) | |
| } catch (e) { | |
| console.log('❌❌❌ Error creating directory', e) | |
| } | |
| } | |
| try { | |
| writeFileSync(path, data) | |
| } catch (e) { | |
| console.error(`❌❌❌ Error creating JSON file: ${path}`, e) | |
| } | |
| } | |
| const storeJsonFile = (path, data) => { | |
| const dirPath = dirname(path) | |
| if (!existsSync(dirPath)) { | |
| try { | |
| mkdirSync(dirPath, { recursive: true }) | |
| } catch (e) { | |
| console.error('Error creating directory at path:', dirPath, e) | |
| } | |
| } | |
| try { | |
| writeFileSync(path, JSON.stringify(data, null, 2)) // Adds indentation for readability | |
| } catch (e) { | |
| console.error('Error writing to JSON file at path:', path, e) | |
| } | |
| } |
etc/ofac.js
Outdated
| const fetchOfac = async () => { | ||
| const response = await fetch( | ||
| 'https://raw.githubusercontent.com/InjectiveLabs/injective-lists/master/wallets/ofac.json', | ||
| ) | ||
| const wallets = await response.text() | ||
|
|
||
| try { | ||
| storeJsonFile(`src/json/ofac.json`, wallets) | ||
|
|
||
| console.log(`✅✅✅ OFAC list fetched`) | ||
| } catch (e) { | ||
| console.error(`❌❌❌ OFAC list NOT fetched`) | ||
| throw e | ||
| } | ||
| } |
There was a problem hiding this comment.
Improve error handling and logging in fetchOfac.
While the function generally handles errors, it could benefit from more detailed error logging and potentially retry logic for network failures. Consider these enhancements:
- console.error(`❌❌❌ OFAC list NOT fetched`)
+ console.error('Failed to fetch OFAC list from URL:', e)
+ // Optional: Implement retry logic
+ let attempts = 0;
+ while (attempts < 3) {
+ try {
+ const response = await fetch('https://raw.githubusercontent.com/InjectiveLabs/injective-lists/master/wallets/ofac.json');
+ if (!response.ok) throw new Error(`HTTP status ${response.status}`);
+ break; // Success
+ } catch (err) {
+ if (attempts >= 2) throw err; // Rethrow after last attempt
+ attempts++;
+ console.log('Retrying fetch...', attempts);
+ }
+ }Committable suggestion was skipped due to low confidence.
| if (ofac.includes(txWithAddresses.ethereumAddress)) { | ||
| throw new GeneralException( | ||
| new Error('You cannot execute this transaction'), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Review the repeated OFAC checks in transaction broadcasting methods.
The OFAC list checks are implemented in multiple methods (broadcast, broadcastV2, broadcastOld, broadcastWithFeeDelegation) to prevent transactions involving restricted addresses. While the checks are crucial for compliance, the repeated code suggests a potential for refactoring to centralize this logic, which would improve maintainability and reduce the risk of errors in updates.
Consider refactoring the OFAC check into a separate method that can be called by these broadcasting methods. This would centralize the compliance logic and reduce code duplication.
Example refactor:
private checkOFACCompliance(address: string): void {
if (ofac.includes(address)) {
throw new GeneralException(new Error('You cannot execute this transaction'));
}
}
// Usage in broadcasting methods:
this.checkOFACCompliance(txWithAddresses.ethereumAddress);Also applies to: 182-186, 216-220, 247-251
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- etc/ofac.js (1 hunks)
- packages/sdk-ts/package.json (1 hunks)
- packages/sdk-ts/src/core/modules/tx/broadcaster/MsgBroadcasterWithPk.ts (4 hunks)
- packages/sdk-ts/src/index.ts (1 hunks)
- packages/sdk-ts/src/json/index.ts (1 hunks)
- packages/sdk-ts/src/json/ofac.ts (1 hunks)
- packages/wallet-ts/src/broadcaster/MsgBroadcaster.ts (5 hunks)
Files skipped from review due to trivial changes (2)
- packages/sdk-ts/src/index.ts
- packages/sdk-ts/src/json/index.ts
Files skipped from review as they are similar to previous changes (2)
- etc/ofac.js
- packages/wallet-ts/src/broadcaster/MsgBroadcaster.ts
Additional comments not posted (1)
packages/sdk-ts/package.json (1)
22-22: Verify the use of experimental features and relative path in the new script.The script
"fetch:ofac"uses the--experimental-fetchflag, which might indicate reliance on unstable features. Verify that this is acceptable for production use. Additionally, the relative path used (./../../etc/ofac.js) assumes a specific working directory structure. Confirm that this path is correct in all expected deployment scenarios.
| export const ofacWallets = [ | ||
| "0x179f48c78f57a3a78f0608cc9197b8972921d1d2", | ||
| "0x1967d8af5bd86a497fb3dd7899a020e47560daaf", | ||
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | ||
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | ||
| "0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a", | ||
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | ||
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | ||
| "0x2f50508a8a3d323b91336fa3ea6ae50e55f32185", | ||
| "0x308ed4b7b49797e1a98d3818bff6fe5385410370", | ||
| "0x3cbded43efdaf0fc77b9c55f6fc9988fcc9b757d", | ||
| "0x3efa30704d2b8bbac821307230376556cf8cc39e", | ||
| "0x48549a34ae37b12f6a30566245176994e17c6b4a", | ||
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | ||
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | ||
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | ||
| "0x530a64c0ce595026a4a556b703644228179e2d57", | ||
| "0x5512d943ed1f7c8a43f3435c85f7ab68b30121b0", | ||
| "0x5a7a51bfb49f190e5a6060a5bc6052ac14a3b59f", | ||
| "0x5f48c2a71b2cc96e3f0ccae4e39318ff0dc375b2", | ||
| "0x6be0ae71e6c41f2f9d0d1a3b8d0f75e6f6a0b46e", | ||
| "0x6f1ca141a28907f78ebaa64fb83a9088b02a8352", | ||
| "0x746aebc06d2ae31b71ac51429a19d54e797878e9", | ||
| "0x77777feddddffc19ff86db637967013e6c6a116c", | ||
| "0x797d7ae72ebddcdea2a346c1834e04d1f8df102b", | ||
| "0x8576acc5c05d6ce88f4e49bf65bdf0c62f91353c", | ||
| "0x901bb9583b24d97e995513c6778dc6888ab6870e", | ||
| "0x961c5be54a2ffc17cf4cb021d863c42dacd47fc1", | ||
| "0x97b1043abd9e6fc31681635166d430a458d14f9c", | ||
| "0x9c2bc757b66f24d60f016b6237f8cdd414a879fa", | ||
| "0x9f4cda013e354b8fc285bf4b9a60460cee7f7ea9", | ||
| "0xa7e5d5a720f06526557c513402f2e6b5fa20b008", | ||
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | ||
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | ||
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | ||
| "0xc455f7fd3e0e12afd51fba5c106909934d8a0e4a", | ||
| "0xca0840578f57fe71599d29375e16783424023357", | ||
| "0xd0975b32cea532eadddfc9c60481976e39db3472", | ||
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | ||
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | ||
| "0xe1d865c3d669dcc8c57c8d023140cb204e672ee4", | ||
| "0xe7aa314c77f4233c18c6cc84384a9247c0cf367b", | ||
| "0xed6e0a7e4ac94d976eebfb82ccf777a3c6bad921", | ||
| "0xf3701f445b6bdafedbca97d1e477357839e4120d", | ||
| "0xfac583c0cf07ea434052c49115a4682172ab6b4f", | ||
| "0xfec8a60023265364d066a1212fde3930f6ae8da7", | ||
| "0xffbac21a641dcfe4552920138d90f3638b3c9fba" |
There was a problem hiding this comment.
Remove duplicate entries in the OFAC wallet list.
The list contains duplicate Ethereum wallet addresses, which could lead to inefficiencies in processing. Consider using a Set to ensure all addresses are unique.
Here's a suggested refactor to ensure uniqueness:
-export const ofacWallets = [
+export const ofacWallets = Array.from(new Set([
"0x179f48c78f57a3a78f0608cc9197b8972921d1d2",
"0x1967d8af5bd86a497fb3dd7899a020e47560daaf",
"0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff",
"0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", // Duplicate
"0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a",
...
"0xfec8a60023265364d066a1212fde3930f6ae8da7",
"0xffbac21a641dcfe4552920138d90f3638b3c9fba"
-]
+]));Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export const ofacWallets = [ | |
| "0x179f48c78f57a3a78f0608cc9197b8972921d1d2", | |
| "0x1967d8af5bd86a497fb3dd7899a020e47560daaf", | |
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | |
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | |
| "0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a", | |
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | |
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | |
| "0x2f50508a8a3d323b91336fa3ea6ae50e55f32185", | |
| "0x308ed4b7b49797e1a98d3818bff6fe5385410370", | |
| "0x3cbded43efdaf0fc77b9c55f6fc9988fcc9b757d", | |
| "0x3efa30704d2b8bbac821307230376556cf8cc39e", | |
| "0x48549a34ae37b12f6a30566245176994e17c6b4a", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x530a64c0ce595026a4a556b703644228179e2d57", | |
| "0x5512d943ed1f7c8a43f3435c85f7ab68b30121b0", | |
| "0x5a7a51bfb49f190e5a6060a5bc6052ac14a3b59f", | |
| "0x5f48c2a71b2cc96e3f0ccae4e39318ff0dc375b2", | |
| "0x6be0ae71e6c41f2f9d0d1a3b8d0f75e6f6a0b46e", | |
| "0x6f1ca141a28907f78ebaa64fb83a9088b02a8352", | |
| "0x746aebc06d2ae31b71ac51429a19d54e797878e9", | |
| "0x77777feddddffc19ff86db637967013e6c6a116c", | |
| "0x797d7ae72ebddcdea2a346c1834e04d1f8df102b", | |
| "0x8576acc5c05d6ce88f4e49bf65bdf0c62f91353c", | |
| "0x901bb9583b24d97e995513c6778dc6888ab6870e", | |
| "0x961c5be54a2ffc17cf4cb021d863c42dacd47fc1", | |
| "0x97b1043abd9e6fc31681635166d430a458d14f9c", | |
| "0x9c2bc757b66f24d60f016b6237f8cdd414a879fa", | |
| "0x9f4cda013e354b8fc285bf4b9a60460cee7f7ea9", | |
| "0xa7e5d5a720f06526557c513402f2e6b5fa20b008", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xc455f7fd3e0e12afd51fba5c106909934d8a0e4a", | |
| "0xca0840578f57fe71599d29375e16783424023357", | |
| "0xd0975b32cea532eadddfc9c60481976e39db3472", | |
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | |
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | |
| "0xe1d865c3d669dcc8c57c8d023140cb204e672ee4", | |
| "0xe7aa314c77f4233c18c6cc84384a9247c0cf367b", | |
| "0xed6e0a7e4ac94d976eebfb82ccf777a3c6bad921", | |
| "0xf3701f445b6bdafedbca97d1e477357839e4120d", | |
| "0xfac583c0cf07ea434052c49115a4682172ab6b4f", | |
| "0xfec8a60023265364d066a1212fde3930f6ae8da7", | |
| "0xffbac21a641dcfe4552920138d90f3638b3c9fba" | |
| export const ofacWallets = Array.from(new Set([ | |
| "0x179f48c78f57a3a78f0608cc9197b8972921d1d2", | |
| "0x1967d8af5bd86a497fb3dd7899a020e47560daaf", | |
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | |
| "0x19aa5fe80d33a56d56c78e82ea5e50e5d80b4dff", | |
| "0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a", | |
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | |
| "0x2f389ce8bd8ff92de3402ffce4691d17fc4f6535", | |
| "0x2f50508a8a3d323b91336fa3ea6ae50e55f32185", | |
| "0x308ed4b7b49797e1a98d3818bff6fe5385410370", | |
| "0x3cbded43efdaf0fc77b9c55f6fc9988fcc9b757d", | |
| "0x3efa30704d2b8bbac821307230376556cf8cc39e", | |
| "0x48549a34ae37b12f6a30566245176994e17c6b4a", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x4f47bc496083c727c5fbe3ce9cdf2b0f6496270c", | |
| "0x530a64c0ce595026a4a556b703644228179e2d57", | |
| "0x5512d943ed1f7c8a43f3435c85f7ab68b30121b0", | |
| "0x5a7a51bfb49f190e5a6060a5bc6052ac14a3b59f", | |
| "0x5f48c2a71b2cc96e3f0ccae4e39318ff0dc375b2", | |
| "0x6be0ae71e6c41f2f9d0d1a3b8d0f75e6f6a0b46e", | |
| "0x6f1ca141a28907f78ebaa64fb83a9088b02a8352", | |
| "0x746aebc06d2ae31b71ac51429a19d54e797878e9", | |
| "0x77777feddddffc19ff86db637967013e6c6a116c", | |
| "0x797d7ae72ebddcdea2a346c1834e04d1f8df102b", | |
| "0x8576acc5c05d6ce88f4e49bf65bdf0c62f91353c", | |
| "0x901bb9583b24d97e995513c6778dc6888ab6870e", | |
| "0x961c5be54a2ffc17cf4cb021d863c42dacd47fc1", | |
| "0x97b1043abd9e6fc31681635166d430a458d14f9c", | |
| "0x9c2bc757b66f24d60f016b6237f8cdd414a879fa", | |
| "0x9f4cda013e354b8fc285bf4b9a60460cee7f7ea9", | |
| "0xa7e5d5a720f06526557c513402f2e6b5fa20b008", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xb6f5ec1a0a9cd1526536d3f0426c429529471f40", | |
| "0xc455f7fd3e0e12afd51fba5c106909934d8a0e4a", | |
| "0xca0840578f57fe71599d29375e16783424023357", | |
| "0xd0975b32cea532eadddfc9c60481976e39db3472", | |
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | |
| "0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b", | |
| "0xe1d865c3d669dcc8c57c8d023140cb204e672ee4", | |
| "0xe7aa314c77f4233c18c6cc84384a9247c0cf367b", | |
| "0xed6e0a7e4ac94d976eebfb82ccf777a3c6bad921", | |
| "0xf3701f445b6bdafedbca97d1e477357839e4120d", | |
| "0xfac583c0cf07ea434052c49115a4682172ab6b4f", | |
| "0xfec8a60023265364d066a1212fde3930f6ae8da7", | |
| "0xffbac21a641dcfe4552920138d90f3638b3c9fba" | |
| ])); |
| if (ofacWallets.includes(privateKey.toHex())) { | ||
| throw new GeneralException( | ||
| new Error('You cannot execute this transaction'), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Refactor repeated OFAC checks and improve error messaging.
The checks against the ofacWallets list are repeated in multiple methods. Consider refactoring this logic into a separate method to reduce code duplication and improve maintainability. Additionally, the error message "You cannot execute this transaction" could be more descriptive, perhaps specifying that the transaction is blocked due to OFAC compliance.
Here's a suggested refactor:
+ private checkOfacCompliance() {
+ const walletHex = this.privateKey.toHex();
+ if (ofacWallets.includes(walletHex)) {
+ throw new GeneralException(
+ new Error('Transaction blocked due to OFAC compliance restrictions.'),
+ );
+ }
+ }
- if (ofacWallets.includes(privateKey.toHex())) {
+ this.checkOfacCompliance();Also applies to: 132-136, 188-192
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style