Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: magic wallet #503

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat: magic wallet #503

merged 1 commit into from
Sep 16, 2024

Conversation

ThomasRalee
Copy link
Collaborator

@ThomasRalee ThomasRalee commented Sep 16, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced support for the Magic wallet, allowing users to authenticate using various methods (Email, Apple, Google, etc.).
    • Enhanced address retrieval functionality with optional parameters for more customization.
  • Bug Fixes

    • Improved wallet strategy handling and categorization, ensuring better integration with Ethereum standards.
  • Documentation

    • Added new type definitions for Magic wallet metadata, enhancing configuration options.

Copy link

coderabbitai bot commented Sep 16, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several enhancements to the wallet-ts package, including the addition of new dependencies for integrating with Magic's services and the Cosmos blockchain. It modifies existing interfaces and classes to accommodate optional parameters for method signatures and introduces a new wallet strategy for the Magic wallet. Additionally, changes to utility functions and enums expand wallet categorization and support for various authentication methods.

Changes

File Path Change Summary
packages/wallet-ts/package.json Added dependencies: @magic-ext/cosmos (v23.9.1), @magic-ext/oauth2 (v9.9.0), magic-sdk (v28.9.0).
packages/wallet-ts/src/strategies/types/strategy.ts Modified getAddresses method in ConcreteCosmosWalletStrategy to accept an optional parameter.
packages/wallet-ts/src/strategies/wallet-strategy/WalletStrategy.ts Modified getAddresses method to accept an optional parameter; added case for Magic wallet in createStrategy.
packages/wallet-ts/src/strategies/wallet-strategy/strategies/Magic.ts Introduced Magic wallet strategy class with methods for authentication, address retrieval, and transaction handling.
packages/wallet-ts/src/strategies/wallet-strategy/types.ts Added MagicMetadata type definition; modified import order.
packages/wallet-ts/src/strategies/wallet-strategy/utils.ts Updated isEthWallet and isEip712V2OnlyWallet functions to include Wallet.Magic.
packages/wallet-ts/src/types/enums.ts Added Magic option to Wallet enum and introduced MagicProvider enum with various authentication methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MagicWallet
    participant WalletStrategy

    User->>WalletStrategy: Request to connect wallet
    WalletStrategy->>MagicWallet: Create Magic wallet strategy
    MagicWallet->>User: Prompt for authentication
    User->>MagicWallet: Provide email and provider
    MagicWallet->>MagicWallet: Enable and poll login state
    MagicWallet->>WalletStrategy: Return wallet addresses
    WalletStrategy->>User: Provide wallet addresses
Loading

🐰 In a world of wallets, bright and new,
Magic hops in, with features to pursue.
With strategies woven, and addresses to find,
A leap into blockchain, oh what a bind!
So gather your tokens, let’s dance and play,
For the Magic wallet is here to stay! 🌟


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ThomasRalee ThomasRalee merged commit 6de5182 into dev Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant