Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.2 backportapalooza #170

Merged

Conversation

CosmicHorrorDev
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev commented Nov 19, 2023

This bundles together all the relevant bug fixes, documentation changes, and refactors/tests that make sense for a patch release. Notably it includes all of these PRs

TODO: This has that zbus issue that causes color theme detection to fail on Linux. Check to see if that's fixed when updating deps Looks like the existing issue should be fixed and I'm now hitting https://bugzilla.redhat.com/show_bug.cgi?id=2239248 🙃

TODO: Need to follow through all the regular release steps. Bump version, update deps, draft up a more coherent description of the changes, etc.


  • Check for unused dependencies
    • $ cargo +nightly udeps
  • Update rust-version in Cargo.toml
    • $ cargo msrv --min 1.60 -- cargo check
  • Bump version in Cargo.toml
  • Run cargo check to propagate changes to Cargo.lock
  • Merge changes through a PR or directly to make sure CI passes
  • Publish on crates.io
    • $ cargo publish
  • Publish on GitHub by pushing a version tag
    • $ git tag v{VERSION} (make sure the branch you are on is up to date)
    • $ git push upstream/origin v{VERSION}
  • Make a release announcement on GitHub after the release workflow finishes

coastalwhite and others added 16 commits November 19, 2023 09:09
* Refactor: Remove unneccesary CLI branching

* Refactor: Refactor configuration load function

* Feat: Add '--config' flag

* Refactor: Reduce passing of args and configuration

* Fix: Fix cli parsing of page width

* Clean: use 'display()' instead of debug print for path

* Clean: use Default for Keybindings

* Refactor: Use Keybindings in tests

* Doc: Fix 'page width' to 'page_width'

* Refactor: use interpolation style

* Refactor: Remove inline on Keybindings::new

* Refactor: Extract Keybindings Default implementation

* Refactor: Destructure Config and Args in opts
* Make correct location of `inlyne.toml` file clearer

* Fix missing backtick
* Cleanup existing custom debug impls

* Add custom debug impls for `Element::Image(_)`

* Add a snapshot test for complex image elements
* The watcher should attempt to re-register on name changes

* Re-register watcher after longer delays

* Add a reminder for fixing watching after file changes

* Move file watcher into its own file

* Make file watcher testable

* Watcher follows file changes

* Test the file watcher

* Final test tweaks

* Swap back to the old delays

* Final final test tweaks

* Use a slightly longer delay

* Shorter poll interval for file watcher

* Follow through with rename
* Rework panic happy file reloading

* Tweak logs

* The watcher should attempt to re-register on name changes

* Re-register watcher after longer delays
* Add failing test

* Use extended syntax definitions

* Add failing test

* Allow for comma as an info string delimiter
* Add failing tests

* Handle nesting of lists

* Cleanup list prefix handling
This solves an issue with the NixOS build where fonts are required at
runtime for inlyne to start. With the `fontconfig` feature flag inlyne
will use font-config to determine a font.

Partially resolves Inlyne-Project#164
@CosmicHorrorDev CosmicHorrorDev changed the title V0.3.2 backportapalooza v0.3.2 backportapalooza Nov 19, 2023
* Use `human-panic` for a custom panic hook

* Indicate that the version is a "git release"
@CosmicHorrorDev
Copy link
Collaborator Author

Whelp... this will have to be on hold until I'm no longer sick 🤒

@CosmicHorrorDev
Copy link
Collaborator Author

@AlphaKeks whenever you have time (no rush at all) could you check to see if this branch still fixes that panic you were experiencing that you recently fixed on main? I just want to make sure things are working before cutting the release

@CosmicHorrorDev CosmicHorrorDev marked this pull request as ready for review November 23, 2023 07:17
@AlphaKeks
Copy link
Contributor

I can confirm that, with nix develop nixpkgs#inlyne followed by cargo build and patching the resulting binary, it does start.

What's weird is that nix run nixpkgs#inlyne works perfectly fine...
I can't tell why, or since when. The upstream package hasn't changed, so I assume this is something specific to my system, but I can't tell you what. It's weird because compiling inlyne manually requires this patchelf dance (and before I opened the original issue it also did with the upstream package!), but the upstream package works (now)...?

I'm honestly confused, but whatever it is, it's not inlyne's issue.

@CosmicHorrorDev
Copy link
Collaborator Author

Well happy to hear that things are working at least!

@CosmicHorrorDev CosmicHorrorDev merged commit 32b71c1 into Inlyne-Project:v0.3 Nov 23, 2023
4 checks passed
@CosmicHorrorDev CosmicHorrorDev deleted the v0.3.2-backportapalooza branch April 6, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants