Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI rewrite #284

Merged
merged 4 commits into from
Mar 23, 2024
Merged

CLI rewrite #284

merged 4 commits into from
Mar 23, 2024

Conversation

kokoISnoTarget
Copy link
Contributor

For #282.
At this point, none of the (CLI)test work (nor compile).
Screenshot_2024-03-23-22-18-27_5120x1263
But now it should be pretty easy to add new functionality to the CLI.

@kokoISnoTarget
Rewrote the ClI to use derive and to be more expandable in the future
c9f83f5 
Signed-off-by: konrad <kokos.kekse@gmail.com>
@kokoISnoTarget
fix: Cli tests
b7f6557 
Signed-off-by: konrad <kokos.kekse@gmail.com>
@kokoISnoTarget
fix: Removed anyhow from Cli so xtask can do its thing.
b6d8f5d 
Signed-off-by: konrad <kokos.kekse@gmail.com>
@kokoISnoTarget
fix: Clippy naming convention
5c3e9a8 
Signed-off-by: konrad <kokos.kekse@gmail.com>
@kokoISnoTarget kokoISnoTarget marked this pull request as ready for review March 23, 2024 22:16
@CosmicHorrorDev CosmicHorrorDev self-requested a review March 23, 2024 22:32
@kokoISnoTarget kokoISnoTarget changed the title WIP: CLI rewrite CLI rewrite Mar 23, 2024
@CosmicHorrorDev CosmicHorrorDev added C-refactor Category: Reworking an existing feature !!breaking change!! Requires a semver breaking release A-CLI Area: Dealing with CLI and related functionality labels Mar 23, 2024
@kokoISnoTarget
Copy link
Contributor Author

Is this a breaking change?

@CosmicHorrorDev
Copy link
Collaborator

Yup, but only in the case of how inlyne view is handled (before it would open a markdown file named "view", while now it runs the subcommand)

@kokoISnoTarget
Copy link
Contributor Author

Oh, you're right.

CosmicHorrorDev
CosmicHorrorDev approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! This is more or less exactly how I was thinking about implementing things :)

@CosmicHorrorDev CosmicHorrorDev merged commit afa874d into Inlyne-Project:main Mar 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosmicHorrorDev CosmicHorrorDev CosmicHorrorDev approved these changes

Assignees
No one assigned
Labels
A-CLI Area: Dealing with CLI and related functionality !!breaking change!! Requires a semver breaking release C-refactor Category: Reworking an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kokoISnoTarget @CosmicHorrorDev