refactor: Fully customize our panic hook #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
force-pushed
the
panic-hook
branch
from
50687bc
to
74f9bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a custom panic hook seemed to really help in terms of both getting people to open issues for panics along with adding a baseline of actionable info with the crash too
That being said, the default instructions to submit bug reports and the format of the report itself could be better tailored to suit our specific needs. This PR attempts to do that by providing simple instructions on searching for similar issues and submitting new issues for our repo instead of the old vague message. It also switches the report style to be a markdown fragment that can be copied to start a github issue since we don't have any kind of automated ingest and processing where a more structured format would make sense