Add double and triple click selection #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokoISnoTarget
changed the title
…e and triple clicking This is still realy broken
…erefore remove some complexity
chore: removed an debug message
CosmicHorrorDev
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Another issue I noticed, but I'm not sure where in the code is the problem, but it seems like the selections pull in another word if you're double-clicking on a 1-2 character word, but 3+ seems fine
Overall most things seem to work great! (like really really great 🚀)
I left feedback on some bits I noticed and then there's also merge conflicts, but I'm super excited to get this merged
… check for the case cursor.index.. would retrun more than desired
kokoISnoTarget
force-pushed
the
double-tripple-click-selection
branch
from
bfd7dfa
to
780a91d
Compare
CosmicHorrorDev
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is and draft pr for #43.