Fix: Updating window title if new file loaded #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following [issue](Inlyne-Project#360) Refactors: Encapsulated updating file watcher and window title into one function Note: This was a regression bug. In previous versions this bug did not exit See the following commit "a6bb495" with version 0.4.1
CosmicHorrorDev
added
C-bug
|
Would you mind switching the base branch to |
|
Well that button didn't do what I wanted. I'll work on fixing the conflicts |
|
Ahhhh. I somehow forgot that this was already working as intended on main with so this would strictly be for the |
|
I think this path is then obsolete in that case. No biggie. Say the word and I close this PR. |
|
Fair enough. I'm sorry that I didn't realize earlier, thanks for your contribution nonetheless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue
Refactors: Encapsulated updating file watcher and window title into one function
Note: This was a regression bug.
In previous versions, this bug did not exit
See the following commit "a6bb495" with version 0.4.1
Reason why PR on branch v0.4
The current version on crates.io seems to use commit 588687e on this branch.
Therefore, the addressed bug comes up when installing inlyne via the following command
It also seems that the most recent changes are done on this branch.