Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Repeat Registration" functionality for plug-in assemblies #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MattTrinder1
Copy link

Adds a "Repeat" button to the toolbar which repeats the previous registration, preventing the need to display the form, select the same assembly etc. Uses the existing functionality from the registration form.
A bit rough and ready but seems to work OK.

@rappen
Copy link
Member

rappen commented Aug 20, 2019

I may be misunderstanding this, but it sounds like it does pretty much what the Plugin Auto Deployer does?
image

This is found in the tool package called Innofactor Tools.
https://www.xrmtoolbox.com/plugins/Cinteros.XrmToolBox.Plugins/

@MattTrinder1
Copy link
Author

Err, yep it does :-) I was unaware of the auto updater. I’ll have a play with that over the next couple of days. I still think this is a useful update to the PRT though.

@rappen
Copy link
Member

rappen commented Aug 21, 2019

@MattTrinder1 - Yep * 2 😊

Copy link
Member

@rappen rappen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to the code:

  1. Changed/Added method signatures to not follow the code style of space after comma. This is also true for some of the code added. This is solved by a simple +K+D in the code.
  2. I don't see why the three new properties should be declared as public, assuming private would be enough? Also I don't see the reason for having them spread around the code, instead of placing them together at the top with other declarations.
  3. New method to handle button click is not placed within proper region.
  4. Instead of re-using button click methods, it would probably be better to extract the functionality to separate methods being called. This would probably also remove the need for the added property AssemblyFileName.

@MattTrinder1
Copy link
Author

Tidied up as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants