Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - use http proxy from env variables #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tgrandje
Copy link
Collaborator

Small PR to :

  • handle corporate proxies when pynsee connection is managed through os environment variables;
  • use proxies during tests ran on a local machine;
  • restore both proxies and credentials after tests are run on a local machine (if keys where stored on disk).

Copy link
Collaborator

@tfardet tfardet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me; as long as the tests pass, I think we can merge this

@tgrandje
Copy link
Collaborator Author

@tfardet obviously the tests fail (again) and this is not due to this PR...
Just to be sure, I'll try to run those on my professionnal laptop monday (behind corporate proxy).

@tgrandje
Copy link
Collaborator Author

tgrandje commented Sep 2, 2024

This passes on my professional laptop (python 3.10), including the utils tests (I did not bother pushing a commit to force testing on all python version, but I ran those) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants