-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image-sets-normalization pipeline #1086
Draft
PaulHax
wants to merge
17
commits into
InsightSoftwareConsortium:main
Choose a base branch
from
PaulHax:dicom-sort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
reviewed
Mar 5, 2024
Notes:
|
thewtex
reviewed
Mar 5, 2024
PaulHax
commented
Mar 12, 2024
thewtex
reviewed
Mar 12, 2024
thewtex
requested changes
Mar 12, 2024
packages/dicom/python/itkwasm-dicom-wasi/test/test_sort_dicom_series.py
Outdated
Show resolved
Hide resolved
packages/dicom/python/itkwasm-dicom-wasi/test/test_sort_dicom_series.py
Outdated
Show resolved
Hide resolved
4837dd0
to
0775d5b
Compare
thewtex
reviewed
Mar 19, 2024
66c9a9f
to
1eb7705
Compare
Change CmakeLists to build image-sets-normalization for WASI. Fix wasi/__init__ to expose image_sets_normalization. Fix generated file import of image in test
Use GDCM discriminate volume example class.
Use DICOMTagReader to get all tags in files
current JSON output AWS Image Set example |
thewtex
reviewed
Mar 26, 2024
thewtex
reviewed
Mar 26, 2024
b8e4822
to
df876af
Compare
refactor DicomFile to struct
Also, remove import of "itkGDCMImageIO.h" by extracting CharStringToUTF8Converter
Rebase started in #1197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art:
Image sets JSON shape:
https://docs.aws.amazon.com/healthimaging/latest/devguide/understanding-image-sets.html
TODO
SpecificCharacterSet
tag andDICOMTagReader::CharStringToUTF8Converter
.set
.gdcmDiscriminateVolume.h
if still unused (may be helpful for instance sorting step)Current output with 2 image series/sets:
actual.json.tar.gz