-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dcmqi seg #1165
Merged
Merged
Dcmqi seg #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
067e54c
to
3f8588f
Compare
7ca1ce7
to
5af2578
Compare
thewtex
reviewed
Jun 28, 2024
cadb20b
to
f4ca151
Compare
010ff79
to
626cfcd
Compare
1c2ed95
to
25c9792
Compare
8fe2dc6
to
e489b3c
Compare
Addresses #991 |
5673a67
to
cabc4c8
Compare
thewtex
previously requested changes
Aug 21, 2024
packages/core/typescript/itk-wasm/src/bindgen/typescript/typescript-bindings.js
Outdated
Show resolved
Hide resolved
Fix the following warning by specifying policy: ``` CMake Warning (dev) at /usr/share/cmake-3.27/Modules/ExternalProject.cmake:3136 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. The policy's OLD behavior will be used. When using a URL download, the timestamps of extracted files should preferably be that of the time of extraction, otherwise code that depends on the extracted contents might not be rebuilt if the URL changes. The OLD behavior preserves the timestamps from the archive instead, but this is usually not what you want. Update your project to the NEW behavior or specify the DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this robustness issue. Call Stack (most recent call first): /usr/share/cmake-3.27/Modules/ExternalProject.cmake:4345 (_ep_add_download_command) gdcm/CMakeLists.txt:46 (ExternalProject_Add) This warning is for project developers. Use -Wno-dev to suppress it. ```
- add native tests - dcmqi itk2Dicom template parameter update
Soft disable browser test for write-overlapping-segmentation because it is flaky right now, possibly due to cypress.
example backtrace: Caused by: 0: failed to invoke command default 1: error while executing at wasm backtrace: 0: 0x654b3 - read-segmentation.wasi.wasm!dlfree 1: 0x6526c - read-segmentation.wasi.wasm!free 2: 0x63872 - read-segmentation.wasi.wasm!operator delete(void*) 3: 0x1f6a5e - read-segmentation.wasi.wasm!std::__2::__tree<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, std::__2::less<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>, std::__2::allocator<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>>::destroy(std::__2::__tree_node<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, void*>*) 4: 0x1f6a33 - read-segmentation.wasi.wasm!std::__2::__tree<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, std::__2::less<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>, std::__2::allocator<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>>::destroy(std::__2::__tree_node<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, void*>*) 5: 0x1f6a33 - read-segmentation.wasi.wasm!std::__2::__tree<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, std::__2::less<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>, std::__2::allocator<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>>::destroy(std::__2::__tree_node<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, void*>*) 6: 0x1f6a33 - read-segmentation.wasi.wasm!std::__2::__tree<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, std::__2::less<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>, std::__2::allocator<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>>>::destroy(std::__2::__tree_node<std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char>>, void*>*) 7: 0x83e402 - read-segmentation.wasi.wasm!__cxx_global_array_dtor.49588 8: 0x691d9 - read-segmentation.wasi.wasm!__funcs_on_exit 9: 0x69383 - read-segmentation.wasi.wasm!__wasm_call_dtors 10: 0x8aa254 - read-segmentation.wasi.wasm!itk_wasm_delayed_exit 11: 0x8aa2dd - read-segmentation.wasi.wasm!_start note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information 2: memory fault at wasm address 0x651f34ec in linear memory of size 0xbb0000
Requires test data from the dcmqi source directory, which is not available in the CI configuration.
d18468d
into
InsightSoftwareConsortium:main
60 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.