Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastDDS v2.11.2 -> 2.10.4 (LTS) #12961

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented May 26, 2024

v2.10.x is eProsima's last LTS version that still supports U20.
We were on v2.11.2, which is already out of support, so any fixes eProsima made for us cannot be on this branch.
Specifically, v2.10.4 includes two of the fixes we asked for:

Feature 3: New max_message_size property to limit output datagrams size (#4807)
Bug fix 31: Fix on_sample_lost notification on best-effort readers for fragmented samples (#4606)

There was a problem when I went to v2.10.4 with the CMake files:

CMake Error in build/third-party/fastdds/src/cpp/CMakeLists.txt:
  export called with target "fastrtps" which requires target "fastcdr" that
  is not in any export set.

CMake Error in build/third-party/fastdds/src/cpp/CMakeLists.txt:
  export called with target "fastrtps" which requires target
  "foonathan_memory" that is not in any export set.

After investigating, it seems v2.11+ made changes in their CMake that were correct and compatible with our code, so when we went back to v2.10 they lost those and our compilation failed. I reported this and so they gave us a special tag that includes these, to be included in v2.10.5 at a later date. For now, we use this special tag.

@maloel maloel requested a review from Nir-Az May 26, 2024 05:24
@maloel maloel merged commit be8e80c into IntelRealSense:development May 26, 2024
16 of 17 checks passed
@maloel maloel deleted the fastdds-2104 branch May 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants