Fixes bugs with copy entities from Position A to Position B #2195
+133
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested each of them on a Plot world |
dordsor21
reviewed
Apr 30, 2023
.../main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_17_R1_2/PaperweightGetBlocks.java
Outdated
Show resolved
Hide resolved
dordsor21
reviewed
Apr 30, 2023
.../main/java/com/sk89q/worldedit/bukkit/adapter/impl/fawe/v1_17_R1_2/PaperweightGetBlocks.java
Outdated
Show resolved
Hide resolved
dordsor21
approved these changes
May 12, 2023
|
i just compiled your bugfix and tested it, the entities including passanger are now copied, but they are now both independent entities and no longer mounted. in my case the pig is no longer sitting on the invisible armorstand and can be moved around |
TheMeinerLP
force-pushed
the
bugfix/2140
branch
from
16c78b6
to
cf5e84f
Compare
|
Bump! |
|
Hey, do we have any news about this? This fix would be very useful for builders who use Block Display Studio to create structures. |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
dordsor21
approved these changes
Sep 1, 2024
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #2140
Fixes #2427
Description
This PR included the fix for passenger of entities and also leashs for other entities.
That means now
//copy -eand//paste -ewill work to 99% correct now for entities except some edge cases.Submitter Checklist
@since TODO.