Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "/p list" default to "/p list mine" #3827

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make "/p list" default to "/p list mine" #3827

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d60038
Made /p list default to /p list mine
ConfusedAlex Oct 5, 2022
6a39126
Removed unnecessary import
ConfusedAlex Oct 5, 2022
cf2e7ad
Added line break beetween java imports and others
ConfusedAlex Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Core/src/main/java/com/plotsquared/core/command/ListCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,7 @@ private String[] getArgumentList(PlotPlayer<?> player) {
}

public void noArgs(PlotPlayer<?> player) {
player.sendMessage(
TranslatableCaption.of("commandconfig.subcommand_set_options_header"),
Templates.of("values", Arrays.toString(getArgumentList(player)))
);
onCommand(player, new String[]{"mine"});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels kinda hacky and dirty imo - The logic for the mine-subcmd should be extracted into a (private) method and called by that. The noArgs method has no real use-case anymore.

}

@Override
Expand Down