Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: decouple input_ids and output_ids #1855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: decouple input_ids and output_ids #1855

wants to merge 1 commit into from

Conversation

zhyncs
Copy link
Collaborator

@zhyncs zhyncs commented Jun 25, 2024

Motivation

as titled

Hi @lzhangzz @irexyc @lvhan028 May you help review this pr? Thanks.

Modification

as titled

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhyncs
Copy link
Collaborator Author

zhyncs commented Jun 28, 2024

There seems to be a problem with the interactive chat from the unit test. I will fix it today.

@zhyncs zhyncs force-pushed the decouple branch 2 times, most recently from 1b511db to 0311ef1 Compare July 10, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhyncs