Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support release pipeline #2581

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

support release pipeline #2581

wants to merge 4 commits into from

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Oct 11, 2024 •
edited
Loading

Motivation

#2498

from lmdeploy import pipeline
pipe = pipeline('/nvme/shared/vicuna-7b-v1.5/')
pipe('hello')
pipe.close()

@lvhan028
Copy link
Collaborator

Can we add context management for pipeline as well?

with pipeline(...) as pipe:
    do stuff

AllentDan
AllentDan reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add __del__?

lvhan028
lvhan028 reviewed Oct 21, 2024
View reviewed changes
lmdeploy/pytorch/engine/engine.py
self.model_agent = None
self._seq_length_buf = None
self._inputs = None
torch._C._cuda_clearCublasWorkspaces()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it? Cannot torch manage it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 left review comments

@AllentDan AllentDan AllentDan approved these changes

@grimoire grimoire grimoire approved these changes

@lzhangzz lzhangzz Awaiting requested review from lzhangzz

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irexyc @lvhan028 @grimoire @AllentDan