update pre-commit config #2683
Open
update pre-commit config #2683
+6,179
−12,372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllentDan
reviewed
Oct 30, 2024
RunningLeon
reviewed
Jan 20, 2025
| hooks: | ||
| - id: flake8 | ||
| args: ["--exclude=lmdeploy/turbomind/triton_models/*,lmdeploy/pytorch/modeling/*", "--max-line-length=79"] | ||
| args: ["--max-line-length=120"] | ||
| - repo: https://github.com/PyCQA/isort |
There was a problem hiding this comment.
should we update --line-length=120 for isort as well? It seems the default value is 79 per here
https://github.com/PyCQA/isort/blob/1c8d963c54a6ed75d5f29e16835dcfba06bd12d3/docs/configuration/options.md#line-length
There was a problem hiding this comment.
I tried. It conflicts to yapf.
isort updates the import section, which might be updated again by yapf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
"--max-line-length=79" is inappropriate for lmdeploy
Changes
refer to mmcv, mmdetection and opencompass to update pre-commit config