-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise dependency bounds for PVP compliance. #67
Merged
jonathanknowles
merged 10 commits into
master
from
jonathanknowles/package-dependency-bounds
Feb 22, 2024
Merged
Revise dependency bounds for PVP compliance. #67
jonathanknowles
merged 10 commits into
master
from
jonathanknowles/package-dependency-bounds
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are inferred automatically.
This also necessitates the use of `build-tool-depends` instead of `build-tools`, which is now deprecated.
Use `extra-doc-files` instead of `extra-source-files`. As recommended by `cabal check`.
As recommended by `cabal check`.
jonathanknowles
force-pushed
the
jonathanknowles/package-dependency-bounds
branch
from
February 22, 2024 09:40
21abf78
to
40eb03a
Compare
jonathanknowles
requested review from
Anviking,
HeinrichApfelmus,
paweljakubas and
Unisay
as code owners
February 22, 2024 09:44
jonathanknowles
changed the title
Revise package dependency bounds for PVP compliance.
Revise dependency bounds for PVP compliance.
Feb 22, 2024
paweljakubas
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
jonathanknowles
deleted the
jonathanknowles/package-dependency-bounds
branch
February 22, 2024 11:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the bounds of package dependencies for compliance with the Haskell PVP Specification.
Additionally, this PR adds CI support for GHC 9.8.
Related Issue
https://cardanofoundation.atlassian.net/browse/ADP-3295