Add support for GHC 9.10.
#74
Conversation
This commit fixes a build failure that occurs when compiling with GHC
version `>= 9.10` and base version `>= 4.20.0.0`:
```
[1 of 2] Compiling Codec.Binary.Bech32.Internal
src/Codec/Binary/Bech32/Internal.hs:93:1: error: [GHC-66111]
The import of ‘Data.Foldable’ is redundant
except perhaps to import instances from ‘Data.Foldable’
To import instances alone, use: import Data.Foldable()
|
93 | import Data.Foldable
| ^^^^^^^^^^^^^^^^^^^^...
```
Related issue:
haskell/core-libraries-committee#167
jonathanknowles
requested review from
Anviking,
HeinrichApfelmus,
paweljakubas and
Unisay
as code owners
jonathanknowles
force-pushed
the
jonathanknowles/support-ghc-9.10
branch
2 times, most recently
from
c05b98e
to
2eb9c30
Compare
jonathanknowles
force-pushed
the
jonathanknowles/support-ghc-9.10
branch
2 times, most recently
from
3014c17
to
26a1802
Compare
| @@ -72,40 +72,73 @@ module Codec.Binary.Bech32.Internal | |||
|
|
|||
| ) where | |||
|
|
|||
| import Prelude | |||
There was a problem hiding this comment.
do you really think it is good idea?
There was a problem hiding this comment.
The release of GHC 9.10.1 made the following change to base:
This leads to the following build failure, when compiled with GHC 9.10.1:
[1 of 2] Compiling Codec.Binary.Bech32.Internal
src/Codec/Binary/Bech32/Internal.hs:93:1: error: [GHC-66111]
The import of ‘Data.Foldable’ is redundant
except perhaps to import instances from ‘Data.Foldable’
To import instances alone, use: import Data.Foldable()
|
93 | import Data.Foldable
| ^^^^^^^^^^^^^^^^^^^^...
The error occurs because foldl' is now imported both by Data.Foldable and by Prelude.
Supposing that we only had to support GHC ≥ 9.10, then we could use either of the following solutions:
- hide
foldl'withimport Prelude hiding (foldl') - remove the redundant
import Data.Foldable (foldl')
However, both of these solutions will lead to compile errors on GHC < 9.10, which we still have to support.
The solution used by this PR is to replace all implicit imports with explicit imports: this should guarantee we import exactly the same set of symbols across different GHC versions.
There was a problem hiding this comment.
@paweljakubas Here's a similar change made in another library: blamario/monoid-subclasses@de06735
There was a problem hiding this comment.
thanks for the explanation! very unfortunate change I must say ....
There was a problem hiding this comment.
thanks for the explanation! very unfortunate change I must say ....
Yeah, I'm guessing it caused headaches for a few people!
On the bright side though, we now have foldl' in Prelude. 😄
jonathanknowles
force-pushed
the
jonathanknowles/support-ghc-9.10
branch
from
34367af
to
4527f06
Compare
This PR adds support for GHC
9.10andbaseversion4.20.0.0.