-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update proposal governance action #152
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/Actions.hs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| {-# LANGUAGE DataKinds #-} | ||
| {-# LANGUAGE GADTs #-} | ||
| {-# LANGUAGE LambdaCase #-} | ||
| {-# LANGUAGE StandaloneDeriving #-} | ||
|
|
||
| module Cardano.CLI.EraBased.Commands.Governance.Actions | ||
| ( AnyStakeIdentifier(..) | ||
| , GovernanceActionCmds(..) | ||
| , EraBasedUpdateProposal(..) | ||
| , EraBasedNewConstitution(..) | ||
| , renderGovernanceActionCmds | ||
| ) where | ||
|
|
||
| import Cardano.Api | ||
| import Cardano.Api.Shelley | ||
|
|
||
| import Cardano.CLI.Types.Common | ||
| import Cardano.CLI.Types.Key | ||
|
|
||
| import Data.Text (Text) | ||
|
|
||
| data GovernanceActionCmds era | ||
| = GovernanceActionCreateConstitution | ||
| (ConwayEraOnwards era) | ||
| EraBasedNewConstitution | ||
| | GovernanceActionCreateUpdateProposal | ||
| (ConwayEraOnwards era) | ||
| EraBasedUpdateProposal | ||
| deriving Show | ||
|
|
||
| data EraBasedNewConstitution | ||
| = EraBasedNewConstitution | ||
| { encDeposit :: Lovelace | ||
| , encStakeCredential :: AnyStakeIdentifier | ||
| , encConstitution :: Constitution | ||
| , encFilePath :: File () Out | ||
| } deriving Show | ||
|
|
||
| renderGovernanceActionCmds :: GovernanceActionCmds era -> Text | ||
| renderGovernanceActionCmds = \case | ||
| GovernanceActionCreateConstitution {} -> | ||
| "governance action create-constitution" | ||
|
|
||
| GovernanceActionCreateUpdateProposal {} -> | ||
| "governance action create-update-proposal" | ||
|
|
||
| data AnyStakeIdentifier | ||
| = AnyStakeKey (VerificationKeyOrHashOrFile StakeKey) | ||
| | AnyStakePoolKey (VerificationKeyOrHashOrFile StakePoolKey) | ||
| deriving Show | ||
|
|
||
|
|
||
| data EraBasedUpdateProposal where | ||
| ConwayOnwardsUpdateProposal | ||
| :: ConwayEraOnwards era | ||
| -> ProtocolParametersUpdate | ||
| -> Lovelace -- ^ Deposit | ||
| -> AnyStakeIdentifier -- ^ Return address | ||
| -> Maybe (File () In) -- ^ Cost model file | ||
| -> File () Out | ||
| -> EraBasedUpdateProposal | ||
| -- TODO: Conway era - add constructor for pre-conway | ||
| -- update proposals. This will require genesis delegate keys | ||
| -- see UpdateProposal type in cardano-api. | ||
|
|
||
| deriving instance Show EraBasedUpdateProposal | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 68 additions & 0 deletions
68
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Actions.hs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| module Cardano.CLI.EraBased.Options.Governance.Actions | ||
| ( pGovernanceActionCmds | ||
| ) where | ||
|
|
||
| import Cardano.Api | ||
|
|
||
| import Cardano.CLI.EraBased.Commands.Governance.Actions | ||
| import qualified Cardano.CLI.EraBased.Legacy as Legacy | ||
| import Cardano.CLI.EraBased.Options.Common | ||
|
|
||
| import Data.Foldable | ||
| import Options.Applicative | ||
| import qualified Options.Applicative as Opt | ||
|
|
||
| pGovernanceActionCmds :: () | ||
| => CardanoEra era | ||
| -> Maybe (Parser (GovernanceActionCmds era)) | ||
| pGovernanceActionCmds era = | ||
| subInfoParser "action" | ||
| ( Opt.progDesc | ||
| $ mconcat | ||
| [ "Governance action commands." | ||
| ] | ||
| ) | ||
| [ pGovernanceActionNewConstitution era | ||
| , pGovernanceActionCreateUpdateProposal era | ||
| ] | ||
|
|
||
|
|
||
| pGovernanceActionNewConstitution | ||
| :: CardanoEra era -> Maybe (Parser (GovernanceActionCmds era)) | ||
| pGovernanceActionNewConstitution = | ||
| featureInEra Nothing (\cOn -> Just $ | ||
| subParser "create-constitution" | ||
| $ Opt.info (pCmd cOn) | ||
| $ Opt.progDesc "Create a constitution.") | ||
| where | ||
| pCmd :: ConwayEraOnwards era -> Parser (GovernanceActionCmds era) | ||
| pCmd cOn = | ||
| fmap (GovernanceActionCreateConstitution cOn) $ | ||
| EraBasedNewConstitution | ||
| <$> pGovActionDeposit | ||
| <*> pAnyStakeIdentifier | ||
| <*> pConstitution | ||
| <*> pFileOutDirection "out-file" "Output filepath of the constitution." | ||
|
|
||
| pAnyStakeIdentifier :: Parser AnyStakeIdentifier | ||
| pAnyStakeIdentifier = | ||
| asum [ AnyStakePoolKey <$> pStakePoolVerificationKeyOrHashOrFile | ||
| , AnyStakeKey <$> pStakeVerificationKeyOrHashOrFile | ||
| ] | ||
|
|
||
| pGovernanceActionCreateUpdateProposal :: CardanoEra era -> Maybe (Parser (GovernanceActionCmds era)) | ||
| pGovernanceActionCreateUpdateProposal = | ||
| featureInEra Nothing (\cOn -> Just $ | ||
| subParser "create-update-proposal" | ||
| $ Opt.info (pCmd cOn) | ||
| $ Opt.progDesc "Create an update proposal.") | ||
| where | ||
| pCmd :: ConwayEraOnwards era -> Parser (GovernanceActionCmds era) | ||
| pCmd cOn = | ||
| fmap (GovernanceActionCreateUpdateProposal cOn) $ | ||
| ConwayOnwardsUpdateProposal cOn | ||
| <$> Legacy.pProtocolParametersUpdate | ||
| <*> pGovActionDeposit | ||
| <*> pAnyStakeIdentifier | ||
| <*> optional (pFileInDirection "cost-model" "Cost model filepath.") | ||
| <*> pFileOutDirection "out-file" "Output filepath of the update proposal." | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be create-param-proposal., or something to similar to distinguish that it's an update to parameters.