Add error type and messages in Cardano.CLI.EraBased.Run

[carbolymer]

Changelog

- description: |
    Add error type and messages in `Cardano.CLI.EraBased.Run`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

n/a

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• The change log section in the PR description has been filled in
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • round trip tests
  • integration tests
    See Running tests for more details
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• The changelog section in the PR is updated to describe the change
• Self-reviewed the diff

[newhoggy]

Are the error types going to follow the command structure or are we doing one large sum type for all our errors?

[newhoggy]

But I think we should not create a distinction between era-based command errors and legacy errors. We can actually share the same types, and in fact it's preferably because it means less changes when we move legacy stuff into era-based.

[newhoggy]

I reckon we should call this type CmdError and put it in Cardano.CLI.EraBased.Error. Then the legacy code can use this type instead later instead of LegacyClientCmdError.

[carbolymer]

We already have ClientCommandErrors in Cardano.CLI.Run. Should we reuse this one as a top-level umbrella error type?

[newhoggy]

Not yet. It includes lots of legacy stuff as members.