Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CHaP index in preparation for 8.3.0 pre #174

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Aug 16, 2023

Changelog

- description: |
    conway related commands
    `create-constitution` now requires: 
       - mainnet or testnet
       - Optionally the previous governance action id 
       - A proposal url and an anchor data hash of the proposal 
       - A constitution url
    `create-new-committee` now requires:
       - mainnet or testnet
       - A proposal url and an anchor data hash of the proposal
       - Optionally the previous governance action id 
    `create-no-confidence` now requires:
       - mainnet or testnet
       - A proposal url and an anchor data hash of the proposal
    `create-treasury-withdrawal` now requires:
       - mainnet or testnet
       - A proposal url and an anchor data hash of the proposal
    `governance vote create` now requires:
       - The governance action identifier
       
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@nfrisby nfrisby force-pushed the nfrisby/preparing-8.3.0-pre branch from 52ce26f to 78881a5 Compare August 16, 2023 16:28
Comment on lines -423 to +439
Ledger.DelegStakeTxCert stakeCredential (Shelley.KeyHash kh) ->
"Stake address delegation" .= object
[ "stake credential" .= stakeCredJson sbe stakeCredential
, "key hash" .= String (textShow kh)
ConwayLedger.UpdateDRepTxCert drepCredential mbAnchor ->
"Drep certificate update" .= object
[ "Drep credential" .= drepCredJson sbe drepCredential
, "anchor " .= mbAnchor
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case expression and a ledger COMPLETE pragma currently disagree, only on this case.

I currently include a commit in this PR that assumes the COMPLETE pragma is right and the case expression was wrong.

But I'm not sure what exactly the body of this UpdateDRepTxCert should be. For example, should it use conwayToObject instead of the drepCredJson I added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Slack, Alexey wrote "yes, complete pragma is right. UpdateDRepTxCert is the new addition".

@Jimbo4350 Jimbo4350 force-pushed the nfrisby/preparing-8.3.0-pre branch 2 times, most recently from 319c34f to 838f702 Compare August 17, 2023 18:56
@nfrisby nfrisby changed the title DO NOT MERGE preparing for Conway 1.7 release DO NOT MERGE preparing 8.3.0 pre Aug 18, 2023
@Jimbo4350 Jimbo4350 force-pushed the nfrisby/preparing-8.3.0-pre branch 4 times, most recently from 26464e6 to 6180614 Compare August 21, 2023 16:32
@Jimbo4350 Jimbo4350 changed the title DO NOT MERGE preparing 8.3.0 pre Bump CHaP index in preparation for 8.3.0 pre Aug 21, 2023
@carbolymer carbolymer mentioned this pull request Aug 22, 2023
10 tasks
@Jimbo4350 Jimbo4350 force-pushed the nfrisby/preparing-8.3.0-pre branch 5 times, most recently from 513c768 to d9058dc Compare August 22, 2023 13:58
@Jimbo4350 Jimbo4350 marked this pull request as ready for review August 22, 2023 13:58
@Jimbo4350 Jimbo4350 force-pushed the nfrisby/preparing-8.3.0-pre branch 4 times, most recently from a7a6345 to 2d0afd3 Compare August 23, 2023 17:09
proposal anchor and maybe previous governance action id relating to the
last new committee proposal.EraBasedNewConstitution

EraBasedNewConstitution: Update fields with the same as above

EraBasedNoConfidence: Update fields with the same as above with the
exception of maybe previous governance action id

EraBasedTreasuryWithdrawal: Update fields with the same as EraBasedNoConfidence

Propagate these changes throughout the cli adding parsers as necessary

Update vote creation to create a voting entry
Update readTxVotes  to read a VotingEntry which consists of the voter's
voting credential, the governance action id of the proposal the vote is
for and the vote itself
@Jimbo4350 Jimbo4350 requested a review from a team as a code owner August 23, 2023 18:31
@disassembler disassembler added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit 4589924 Aug 23, 2023
23 checks passed
@disassembler disassembler deleted the nfrisby/preparing-8.3.0-pre branch August 23, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants