Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept script hash in stake-and-vote-delegation-certificate command #264

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Accept script hash in stake-and-vote-delegation-certificate command #264

merged 2 commits into from
Sep 12, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 9, 2023

Changelog

- description: |
    Accept script hash in `stake-and-vote-delegation-certificate` command
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 9, 2023 03:58
@newhoggy newhoggy force-pushed the newhoggy/support-for-drep-script-hash branch from 20e7874 to 0bb00f0 Compare September 9, 2023 04:15
Jimbo4350
Jimbo4350 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cardano-cli/src/Cardano/CLI/Read.hs
@@ -1028,3 +1031,6 @@ readSafeHash =
Opt.eitherReader $ \s ->
readHexAsSafeHash (Text.pack s)
& first (Text.unpack . renderReadSafeHashError)

scriptHashReader :: Opt.ReadM ScriptHash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the error look like if it's an invalid script hash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. It's a pre-existing function moved from Cardano.CLI.EraBased.Options.Governance.DRep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to not fail at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be broken, but I'm merging this on the basis that it's not a regression. We're just moving this flag from the drep delegation-certificate command which will soon be deleted. Will need to follow up on whether this flag actually works.

@newhoggy newhoggy force-pushed the newhoggy/support-for-drep-script-hash branch from 0bb00f0 to c3aebf3 Compare September 12, 2023 06:05
@newhoggy newhoggy force-pushed the newhoggy/support-for-drep-script-hash branch 2 times, most recently from 032b932 to 7182504 Compare September 12, 2023 07:26
@newhoggy newhoggy force-pushed the newhoggy/support-for-drep-script-hash branch from 7182504 to 268d02d Compare September 12, 2023 07:55
@newhoggy newhoggy added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 39c1d73 Sep 12, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/support-for-drep-script-hash branch September 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer carbolymer approved these changes

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @carbolymer @Jimbo4350