Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix haddocks generation in GHA #278

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 14, 2023

Changelog

- description: |
    Fix haddocks generation in GHA 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
   - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/fix-haddocks-gha branch 2 times, most recently from 26ce73d to a9fdaaf Compare September 14, 2023 14:01
@carbolymer carbolymer marked this pull request as ready for review September 14, 2023 14:01
@smelc
Copy link
Contributor

smelc commented Sep 15, 2023

Checked that there seemed to be no copy/paste crumbs coming from the same cardano-api PR. Found none, so LGTM 👍

@carbolymer carbolymer added this pull request to the merge queue Sep 15, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Sep 15, 2023
@carbolymer carbolymer force-pushed the mgalazyn/chore/fix-haddocks-gha branch from a9fdaaf to c649457 Compare November 9, 2023 15:18
@carbolymer carbolymer added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit fb1812f Nov 9, 2023
18 of 19 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/fix-haddocks-gha branch November 9, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants