-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for registration of DRep scripts #563
Conversation
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Hash.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Hash.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
Nice design ❤️ |
f899159
to
f7d782d
Compare
| GovernanceHashSourceTextFile (File ProposalText In) | ||
| GovernanceHashSourceText Text | ||
data GovernanceAnchorDataHashSource | ||
= GovernanceAnchorDataHashSourceBinaryFile (File ProposalText In) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ProposalText
for binary files is quite misleading here. We should use use a different type here. Not necessarily within the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened an issue for that: #568
Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com> Reintroduce accidentally deleted cpp
f7d782d
to
f8f652c
Compare
Changelog
Context
This PR closes #559. The issue proposes adding a
--script-hash
and a--script-file
flag to theconway governance drep registration-certificate
command. In the spirit of #442, I choose to implement only one of these flags, as--drep-script-hash
, and instead add a new sub-command to theconway governance hash
command, to enable computation of script hashes. This is done in bf65a3a.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist