Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for registration of DRep scripts #563

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Jan 9, 2024

Changelog

- description: |
     - add support for registration of script DReps;
     - rework the `conway governance hash` command: separate sub-commands for anchor data and scripts
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR closes #559. The issue proposes adding a --script-hash and a --script-file flag to the conway governance drep registration-certificate command. In the spirit of #442, I choose to implement only one of these flags, as --drep-script-hash, and instead add a new sub-command to the conway governance hash command, to enable computation of script hashes. This is done in bf65a3a.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Jan 10, 2024

Nice design ❤️

@carlhammann carlhammann force-pushed the ch/register-drep-scripts branch 2 times, most recently from f899159 to f7d782d Compare January 12, 2024 14:48
| GovernanceHashSourceTextFile (File ProposalText In)
| GovernanceHashSourceText Text
data GovernanceAnchorDataHashSource
= GovernanceAnchorDataHashSourceBinaryFile (File ProposalText In)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProposalText for binary files is quite misleading here. We should use use a different type here. Not necessarily within the scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue for that: #568

@carlhammann carlhammann added this pull request to the merge queue Jan 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 15, 2024
@carlhammann carlhammann added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit e3a1466 Jan 15, 2024
16 checks passed
@carlhammann carlhammann deleted the ch/register-drep-scripts branch January 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add support for registering scripts as DReps.
3 participants