Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency update for the Cardano Node 8.12 release #789

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Dependency update for the Cardano Node 8.12 release #789

merged 4 commits into from
Jun 19, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jun 17, 2024 •
edited
Loading

Changelog

- description: |
    Pre-integration for cardano-node 8.12 release
    `cardano-cli transaction build ... --calculate-plutus-script-cost` now returns the execution logs of the scripts
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-in-preparation-cardano-node-8.12 branch 3 times, most recently from 090a3f8 to af02f41 Compare June 17, 2024 14:04
@disassembler disassembler mentioned this pull request Jun 17, 2024
Closed
@Unisay Unisay mentioned this pull request Jun 18, 2024
Closed
13 tasks
@Unisay Unisay force-pushed the jordan/bump-in-preparation-cardano-node-8.12 branch 3 times, most recently from c47aeae to 84f1efb Compare June 19, 2024 15:04
Jimbo4350 and others added 3 commits June 19, 2024 17:37
@Jimbo4350 @Unisay
Add the following fields for PV2 cost model:
3aaf840 
    "byteStringToInteger-cpu-arguments-c0"
    "byteStringToInteger-cpu-arguments-c1"
    "byteStringToInteger-cpu-arguments-c2"
    "byteStringToInteger-memory-arguments-intercept"
    "byteStringToInteger-memory-arguments-slope"
    "integerToByteString-cpu-arguments-c0"
    "integerToByteString-cpu-arguments-c1"
    "integerToByteString-cpu-arguments-c2"
    "integerToByteString-memory-arguments-intercept"
    "integerToByteString-memory-arguments-slope"
Add the following fields to the PV3 cost model:
    "divideInteger-cpu-arguments-model-arguments-minimum"
    "divideInteger-cpu-arguments-model-arguments-c20"
    "divideInteger-cpu-arguments-model-arguments-c11"
    "divideInteger-cpu-arguments-model-arguments-c10"
    "divideInteger-cpu-arguments-model-arguments-c02"
    "divideInteger-cpu-arguments-model-arguments-c01"
    "divideInteger-cpu-arguments-model-arguments-c00"
    "modInteger-cpu-arguments-model-arguments-minimum"
    "modInteger-cpu-arguments-model-arguments-c20"
    "modInteger-cpu-arguments-model-arguments-c11"
    "modInteger-cpu-arguments-model-arguments-c10"
    "modInteger-cpu-arguments-model-arguments-c02"
    "modInteger-cpu-arguments-model-arguments-c01"
    "modInteger-cpu-arguments-model-arguments-c00"
    "quotientInteger-cpu-arguments-model-arguments-minimum"
    "quotientInteger-cpu-arguments-model-arguments-c20"
    "quotientInteger-cpu-arguments-model-arguments-c11"
    "quotientInteger-cpu-arguments-model-arguments-c10"
    "quotientInteger-cpu-arguments-model-arguments-c02"
    "quotientInteger-cpu-arguments-model-arguments-c01"
    "quotientInteger-cpu-arguments-model-arguments-c00"
    "remainderInteger-cpu-arguments-model-arguments-c20"
    "remainderInteger-cpu-arguments-model-arguments-c11"
    "remainderInteger-cpu-arguments-model-arguments-c10"
    "remainderInteger-cpu-arguments-model-arguments-c02"
    "remainderInteger-cpu-arguments-model-arguments-c01"
    "remainderInteger-cpu-arguments-model-arguments-c00"
    "remainderInteger-cpu-arguments-model-arguments-minimum"

Modify `governanceActionId` to use Word16 instead of Word32
@Unisay
Remove ConwayVote data definition as it was not being used
0d9eb83
@Unisay
Fix type errors
ea6d400
@Unisay Unisay force-pushed the jordan/bump-in-preparation-cardano-node-8.12 branch 2 times, most recently from 1ab2029 to 2e96e30 Compare June 19, 2024 15:40
@Unisay Unisay changed the title Pre-integration for the Cardano Node 8.12 release Dependency update for the Cardano Node 8.12 release Jun 19, 2024
@Unisay Unisay marked this pull request as ready for review June 19, 2024 15:41
@Unisay Unisay force-pushed the jordan/bump-in-preparation-cardano-node-8.12 branch from 2e96e30 to 478f9f5 Compare June 19, 2024 16:09
@disassembler disassembler added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 0d750dd Jun 19, 2024
21 checks passed
@disassembler disassembler deleted the jordan/bump-in-preparation-cardano-node-8.12 branch June 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jimbo4350 @carbolymer @disassembler @Unisay