Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --fee mandatory in legacy transaction build-raw #797

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Make `--fee` mandatory in legacy transaction build-raw
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #796

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/make-fee-mandatory-in-legacy-transaction-build-raw branch from 811de9d to 13142cb Compare June 21, 2024 13:50
@carbolymer carbolymer requested a review from mkoura June 21, 2024 13:51
@carbolymer carbolymer added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 0e085e6 Jun 24, 2024
21 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/make-fee-mandatory-in-legacy-transaction-build-raw branch June 24, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--fee still not mandatory for build-raw in default command group
3 participants