-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Haskell Language Server check to CI #798
Conversation
31d7b9f
to
a08d7cd
Compare
5d262d3
to
f850dd7
Compare
f5c2e12
to
05d4c08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the version bump. This GHA however takes 20 minutes, which is too long of a wait for each PR to get merged.
I don't remember, can you confirm that each PR will wait for this new check to complete before merging?
@carbolymer> right now the new check is not required so we can merge manually before this new check is finished. Regarding the merge queue's behavior, the documentation says it waits for required checks to be satisfied. So not sure if it merges as soon as required checks are green, ignoring the others. I'd be surprised if it was the case. |
119da45
to
20f12c2
Compare
da5a618
to
db80b81
Compare
It takes 4 min now on cache hit. And, it is my understanding, that it should hit cache as long as dependencies for the project don't change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it takes 4 mins, I'm fine with it! 🚀
f0cf09a
to
c530d9a
Compare
62903e1
to
d24b4f9
Compare
23300c7
to
a5c44a6
Compare
a5c44a6
to
5f547a1
Compare
5f547a1
to
38e6e28
Compare
Co-authored-by: Clément Hurlin <smelc@users.noreply.github.com>
38e6e28
to
37edd99
Compare
This PR adds a check to the CI that ensures that it works with the developer shell as it is.
Changelog
Context
Recently we had an issue with HLS not working because of a bug. We could have catched that if we had a test in the CI that ensured HLS worked. This PR aims to address this.
How to trust this PR
Check the workflow makes sense. But basically, I would just look at the CI's output.
Checklist