-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build aarch64-linux binary in Hydra + use static binary for x86-64 Linux release #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angerman
requested review from
a team,
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
July 4, 2024 08:29
carbolymer
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot Moritz!
smelc
changed the title
add aarch64-linux (static) cross
Build aarch64-linux binary in Hydra + use static binary for x86-64 Linux release
Jul 5, 2024
smelc
approved these changes
Jul 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jul 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixes #815
How to trust this PR
Try downloading the binaries built by Hydra and witness that the binaries are statically linked with
file
:For the release pipeline, you can check the same by downloading assets from this run: https://github.com/IntersectMBO/cardano-cli/actions/runs/9806337722 and execute
file
on the downloaded files:(note that this run was triggered from https://github.com/IntersectMBO/cardano-cli/commits/smelc/cross/ to circumvent that some Hydra
required
checks did not pass on this PR's HEAD).Checklist