Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide free instances of HashCheckParamInfo into functions #921

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 2, 2024

Changelog

- description: |
    Hid free instances of `HashCheckParamInfo` to improve type safety
  type:
  - refactoring    # QoL changes

Context

This addresses post-merge reviews in #915

How to trust this PR

Ensure this is a refactoring and that the new design is robust.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Oct 3, 2024

More consistent with the rest of the same file, nice 💯

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at pScriptDataOrFile. It is generically defined.

We create a new parser and name it appropriately e.g pTxHashScriptData

So we can remove HashCheckParamInfo.

@palas palas enabled auto-merge October 3, 2024 14:54
@palas palas added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@palas palas added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 685c5fd Oct 3, 2024
26 checks passed
@palas palas deleted the add-hash-validation2.5 branch October 3, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants