Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move key commands to top level #931

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 8, 2024

Partly resolves: #926

Changelog

- description: |
    Move key commands to top level as they are era agnostic

  type:
  - feature        
  - compatible    

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/move-key-commands-to-top-level branch 2 times, most recently from 4219cb1 to 3e14071 Compare October 8, 2024 19:39
@Jimbo4350 Jimbo4350 marked this pull request as ready for review October 8, 2024 19:39
@Jimbo4350 Jimbo4350 force-pushed the jordan/move-key-commands-to-top-level branch from 3e14071 to f2d454b Compare October 8, 2024 19:42
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always good to get rid of useless generalization 👍

@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@palas palas added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 10, 2024
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 184b794 Oct 11, 2024
26 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/move-key-commands-to-top-level branch October 11, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - cardano-cli compatibility command
3 participants