Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary era parameters and use ShelleyBasedEra era #935

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Remove unnecessary era parameters and use ShelleyBasedEra era #935

merged 6 commits into from
Oct 15, 2024

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Remove unnecessary era parameters and replace `CardanoEra era` with `ShelleyBasedEra era` where appropriate
  type:
  - refactoring

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-unnecessary-era-parameters branch from 36d62de to 4a84aa1 Compare October 11, 2024 14:49
smelc
smelc approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification 👍

cardano-cli/src/Cardano/CLI/EraBased/Commands.hs Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/EraBased/Options/StakeAddress.hs Outdated Show resolved Hide resolved
@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-unnecessary-era-parameters branch from ac20e3a to 5574be2 Compare October 15, 2024 19:28
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 6c2e1c2 Oct 15, 2024
25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/remove-unnecessary-era-parameters branch October 15, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smelc smelc smelc approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@palas palas Awaiting requested review from palas

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jimbo4350 @carbolymer @smelc