Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependencies from ouroboros-* #957

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Oct 30, 2024

Changelog

- description: |
    Removed dependencies from `ouroboros-*`.
# uncomment types applicable to the change:
  type:
  - refactoring

Context

As part of the work targeted at addressing issues pointed out in IntersectMBO/cardano-api#608, this PR aims to remove all direct dependencies of cardano-cli from consensus and network.

How to trust this PR

Make sure it is just a refactoring.

Look at it in conjunction with: IntersectMBO/cardano-api#667

Take advantage that there are one commit for each dependency, (same for the corresponding PR in cardano-api)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Nov 6, 2024
@palas palas self-assigned this Nov 6, 2024
@palas palas force-pushed the remove-transitive-deps-consensus branch from 86deb69 to 8329525 Compare November 14, 2024 17:37
@palas palas enabled auto-merge November 14, 2024 17:38
@palas palas added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 5fc3d31 Nov 14, 2024
25 checks passed
@palas palas deleted the remove-transitive-deps-consensus branch November 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Documentation and Integration Clarification
4 participants