Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parser of transaction outputs and minting policies stricter #958

Closed
wants to merge 3 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 30, 2024

Changelog

- description: |
    Make parser of transaction outputs and minting policies stricter
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #904

How to trust this PR

TBD

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/adapt-to-api-value-parser-split branch from 4313795 to 96b542d Compare November 5, 2024 10:30
@smelc smelc force-pushed the smelc/adapt-to-api-value-parser-split branch from 96b542d to bf76b55 Compare November 5, 2024 11:15
@smelc smelc added next-release next-update Needs a dependency to be updated to be merged and removed next-release labels Nov 6, 2024
@smelc
Copy link
Contributor Author

smelc commented Nov 13, 2024

Closing as it is being integrated in #967

@smelc smelc closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative values are not checked when building tx and ledger exception is returned
1 participant