Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release plutus-1.10.0.0 #432

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Release plutus-1.10.0.0 #432

merged 5 commits into from
Aug 9, 2023

Conversation

effectfully
Copy link
Contributor

No description provided.

@effectfully effectfully requested a review from a team as a code owner August 8, 2023 15:19
@bezirg
Copy link
Contributor

bezirg commented Aug 8, 2023

I think it's better to have a git commit hash in the rev field, it is more definite. See e.g. https://github.com/input-output-hk/cardano-haskell-packages/blob/main/_sources/plutus-ledger-api/1.9.0.0/meta.toml

@michaelpj
Copy link
Contributor

Yeah, we've generally been using a hash. It's less obviously correct... but tags are technically mutable. It's not clear what the best policy is, but so far we've mostly been using hashes.

@effectfully
Copy link
Contributor Author

Makes sense, I'll fix it.

@effectfully
Copy link
Contributor Author

Fixed.

@bezirg
Copy link
Contributor

bezirg commented Aug 8, 2023

@effectfully Isn't this the hash? IntersectMBO/plutus@24399d7

Hash: 24399d7c134f981ef00b74bbfe905b7980583e24

Maybe you took the hash of the PR? GH usually rewrites the pr commit when it squashes and rewrites the commit message also

@effectfully
Copy link
Contributor Author

Maybe you took the hash of the PR?

Nope:

[plutus-shell]$ git tag -d 1.10.0.0
Deleted tag '1.10.0.0' (was 53ffd7f67)
[plutus-shell]$ git fetch --tags
<...>
[plutus-shell]$ git rev-parse 1.10.0.0
53ffd7f67b904822eac2857985499491c545b049

git show 53ffd7f67b904822eac2857985499491c545b049 starts like this:

tag 1.10.0.0
Tagger: effectfully <effectfully@gmail.com>
Date:   Tue Aug 8 17:11:53 2023 +0200

1.10.0.0

commit 24399d7c134f981ef00b74bbfe905b7980583e24 (tag: 1.10.0.0)
Author: effectfully <effectfully@gmail.com>
Date:   Thu Aug 3 11:28:35 2023 +0200

    [Release] 1.10.0.0 (#5452)

diff --git a/doc/read-the-docs-site/plutus-doc.cabal b/doc/read-the-docs-site/plutus-doc.cabal
index 916f0652b..50a06fc29 100644
--- a/doc/read-the-docs-site/plutus-doc.cabal
+++ b/doc/read-the-docs-site/plutus-doc.cabal
@@ -77,9 +77,9 @@ executable doc-doctests
     , containers
     , flat               ^>=0.6
     , lens
-    , plutus-core        ^>=1.9
-    , plutus-ledger-api  ^>=1.9
-    , plutus-tx          ^>=1.9
+    , plutus-core        ^>=1.10
+    , plutus-ledger-api  ^>=1.10
+    , plutus-tx          ^>=1.10

You can see that it includes the commit you reference. I suppose git tag creates its own hash.

Are you sure we should include the hash of the commit rather than the hash of the tag? I'll change it then.

@zliu41
Copy link
Member

zliu41 commented Aug 8, 2023

@effectfully Based on this, the hash should be the one @bezirg said.

$ git rev-parse 1.10.0.0^{commit}
24399d7c134f981ef00b74bbfe905b7980583e24

@zliu41
Copy link
Member

zliu41 commented Aug 8, 2023

Actually perhaps either one is fine. But commit hash should definitely work.

@effectfully effectfully enabled auto-merge (squash) August 8, 2023 21:43
@effectfully
Copy link
Contributor Author

But commit hash should definitely work.

OK, perfect, changed it to the commit hash and enabled auto-merge.

@michaelpj
Copy link
Contributor

Sorry, something else got merged, so you need to rebase and fix the timestamps, see the README

@bezirg bezirg disabled auto-merge August 9, 2023 10:07
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
@effectfully effectfully merged commit 22a8782 into main Aug 9, 2023
@effectfully effectfully deleted the release/plutus/1.10.0.0 branch August 9, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants