-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release plutus-1.10.0.0 #432
Conversation
I think it's better to have a git commit hash in the rev field, it is more definite. See e.g. https://github.com/input-output-hk/cardano-haskell-packages/blob/main/_sources/plutus-ledger-api/1.9.0.0/meta.toml |
Yeah, we've generally been using a hash. It's less obviously correct... but tags are technically mutable. It's not clear what the best policy is, but so far we've mostly been using hashes. |
Makes sense, I'll fix it. |
2e9fb59
to
8f5f958
Compare
Fixed. |
@effectfully Isn't this the hash? IntersectMBO/plutus@24399d7 Hash: 24399d7c134f981ef00b74bbfe905b7980583e24 Maybe you took the hash of the PR? GH usually rewrites the pr commit when it squashes and rewrites the commit message also |
Nope:
You can see that it includes the commit you reference. I suppose Are you sure we should include the hash of the commit rather than the hash of the tag? I'll change it then. |
@effectfully Based on this, the hash should be the one @bezirg said.
|
Actually perhaps either one is fine. But commit hash should definitely work. |
8f5f958
to
6781123
Compare
OK, perfect, changed it to the commit hash and enabled auto-merge. |
Sorry, something else got merged, so you need to rebase and fix the timestamps, see the README |
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
From https://github.com/input-output-hk/plutus at 24399d7c134f981ef00b74bbfe905b7980583e24
6781123
to
3b1fd99
Compare
No description provided.