-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build haddock in CI #441
Build haddock in CI #441
Conversation
Ah indeed, we do know that haddock for things that depend on the plutus-tx plugin doesn't work. Not sure what the best way to exclude that is 🤔 |
Okay, this works but it's not very beautiful, wdyt @andreabedini ? |
It looks ok to me. I allowed myself to make a little change to get the haddock published by Hydra. Maybe, I might need to pass them to the aggregate; also I never understood why Hydra is not showing the constituents. |
Finally I figured out!
The jobs you aggregate still have to be in the set of hydra jobs! |
This reverts commit 76abb8f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, although it seems like we had a weird merge at some point.
I believe the evaluation is better since what we are returning depends on all parameters. Having two arguments might still make sense at the caller site.
This should ensure nothing gets published with broken haddock. Let's see if we get away with it...