Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build haddock in CI #441

Merged
merged 19 commits into from
Aug 24, 2023
Merged

Build haddock in CI #441

merged 19 commits into from
Aug 24, 2023

Conversation

michaelpj
Copy link
Contributor

  • Misc improvements around specification of compilers
  • Build haddock derivations for components that have them

This should ensure nothing gets published with broken haddock. Let's see if we get away with it...

@michaelpj michaelpj requested a review from a team as a code owner August 18, 2023 09:38
@michaelpj
Copy link
Contributor Author

Ah indeed, we do know that haddock for things that depend on the plutus-tx plugin doesn't work. Not sure what the best way to exclude that is 🤔

@michaelpj
Copy link
Contributor Author

Okay, this works but it's not very beautiful, wdyt @andreabedini ?

@andreabedini andreabedini self-assigned this Aug 21, 2023
@andreabedini andreabedini requested review from a team as code owners August 22, 2023 05:12
@andreabedini
Copy link
Contributor

It looks ok to me. I allowed myself to make a little change to get the haddock published by Hydra. Maybe, I might need to pass them to the aggregate; also I never understood why Hydra is not showing the constituents.

@andreabedini
Copy link
Contributor

Finally I figured out!

15:39:28 hydra-evaluator.1    | aggregate job ‘jobs.test’ has a constituent ‘/nix/store/04w2zdarr340slal8m9c25ccglvciqx5-cardano-node-lib-cardano-node-8.2.1-haddock.drv’ that doesn't correspond to a Hydra build
15:39:28 hydra-evaluator.1    | aggregate job ‘jobs.test’ has a constituent ‘/nix/store/33yg9xhz0qb4028k2306dyz7bs50smq7-cardano-node-lib-cardano-node-8.2.1.drv’ that doesn't correspond to a Hydra build
15:39:28 hydra-evaluator.1    | aggregate job ‘jobs.test’ has a constituent ‘/nix/store/j36fqba1ypli6sncfsma2910rlrvra1z-cardano-node-exe-cardano-node-8.2.1.drv’ that doesn't correspond to a Hydra build

The jobs you aggregate still have to be in the set of hydra jobs!

Copy link
Contributor Author

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although it seems like we had a weird merge at some point.

flake.nix Outdated Show resolved Hide resolved
nix/builder.nix Outdated Show resolved Hide resolved
nix/builder.nix Outdated Show resolved Hide resolved
I believe the evaluation is better since what we are returning depends
on all parameters. Having two arguments might still make sense at the
caller site.
@michaelpj michaelpj enabled auto-merge (squash) August 24, 2023 12:37
@michaelpj michaelpj merged commit d4614d8 into main Aug 24, 2023
7 checks passed
@michaelpj michaelpj deleted the mpj/ci-improvements branch August 24, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants