Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus: mark private sublibs as unbuildable #446

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Aug 21, 2023

Alternative to #445, see https://github.com/input-output-hk/cardano-haskell-packages/pull/445#issuecomment-1685878155

Revision diff is just adding the respective else buildable: False branches; will be mirrored in Consensus if this PR is merged.

@michaelpj
Copy link
Contributor

Note you only need to do this in libraries that depend on the private sublibraries, so you could skip e.g. ouroboros-consensus-cardano.

@amesgen
Copy link
Member Author

amesgen commented Aug 21, 2023

@amesgen amesgen closed this Aug 21, 2023
@amesgen amesgen deleted the amesgen/consensus-sublibs-visible-xor-unbuildable branch August 21, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants