[Builtins] Add the 'dropList' builtin #6468
Conversation
effectfully
added
Do not merge
Builtins
EXPERIMENT
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
017e9d4
to
df4dea7
Compare
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
df4dea7
to
7be8e1f
Compare
…to effectfully/builtins/add-dropList
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
7be8e1f
to
e22a57b
Compare
…to effectfully/builtins/add-dropList
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/add-dropList
branch
from
16db02d
to
41ea9b6
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
| @@ -1557,6 +1558,18 @@ instance uni ~ DefaultUni => ToBuiltinMeaning uni DefaultFun where | |||
| nullListDenotation | |||
| (runCostingFunOneArgument . paramNullList) | |||
|
|
|||
| toBuiltinMeaning _semvar DropList = | |||
| let dropListDenotation :: Int -> SomeConstant uni [a] -> BuiltinResult (Opaque val [a]) | |||
There was a problem hiding this comment.
The time taken for this will probably be linear in the value (not the size!) of the first argument. That'll mean susing some newtype wrapper, like this . We already have IntegerCostedLiterally, but this has an Int so that may need another wrapper.
There was a problem hiding this comment.
^ @ramsay-t FYI
but this has an
Intso that may need another wrapper.
Actually, why did I even make it Int, what's the point? Looks like a thinko.
| @@ -82,6 +82,7 @@ module PlutusTx.Builtins ( | |||
| , headMaybe | |||
| , BI.head | |||
| , BI.tail | |||
| , BI.drop | |||
There was a problem hiding this comment.
Should this also go in PlutusTx.Prelude? I seem to remember that the contents of that file are kind of random though.
| @@ -408,6 +409,10 @@ chooseList :: BuiltinList a -> b -> b -> b | |||
| chooseList (BuiltinList []) b1 _ = b1 | |||
| chooseList (BuiltinList (_:_)) _ b2 = b2 | |||
|
|
|||
| {-# OPAQUE drop #-} | |||
| drop :: Integer -> BuiltinList a -> BuiltinList a | |||
There was a problem hiding this comment.
Why not dropList? So that it just replaces the Haskell version with minimal effort from the user?
There was a problem hiding this comment.
For consistency, we also have head (and not headList) and tail (and not tailList) in this file.
This experiment adds the
dropListbuiltin so that folks can play with it. Not intended for merging.