Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off lower prio appliances to switch on higher prio appliances #72

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Maik7
Copy link
Contributor

@Maik7 Maik7 commented Jun 8, 2024

No description provided.

@Maik7
Copy link
Contributor Author

Maik7 commented Jun 8, 2024

#55

Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks this looks good, just noted some typos, may be worth noting that there will be a spike in power over the produced power before the lower priority ones are turned off

PV_Excess_Control/pyscript/pv_excess_control.py Outdated Show resolved Hide resolved
PV_Excess_Control/pyscript/pv_excess_control.py Outdated Show resolved Hide resolved
Maik7 and others added 2 commits June 8, 2024 22:58
Co-authored-by: Carlos Sanchez <carlos@apache.org>
Co-authored-by: Carlos Sanchez <carlos@apache.org>
@Maik7
Copy link
Contributor Author

Maik7 commented Jun 8, 2024

thanks this looks good, just noted some typos, may be worth noting that there will be a spike in power over the produced power before the lower priority ones are turned off

:-) Yes, but in general this is the normal behavior of this script. An appliance is switched off, if the produced power isn't sufficient. And many appliances do not need the full power directly after being switched on. And the lower prioritized appliances will be switched off only a few ms later. Therefore I think it is better this way, than to wait one minute before switching on.

Thank you very much for your suggestions, all of them are now in this PR.

Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 typos

PV_Excess_Control/pyscript/pv_excess_control.py Outdated Show resolved Hide resolved
PV_Excess_Control/pyscript/pv_excess_control.py Outdated Show resolved Hide resolved
Maik7 and others added 2 commits June 16, 2024 23:36
Co-authored-by: Carlos Sanchez <carlos@apache.org>
Co-authored-by: Carlos Sanchez <carlos@apache.org>
@Maik7
Copy link
Contributor Author

Maik7 commented Jun 16, 2024

just 2 typos

Thank you :-)

Copy link
Contributor

@carlossg carlossg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run with this patch for some days and it looks to be working correctly

PV_Excess_Control/pyscript/pv_excess_control.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Sanchez <carlos@apache.org>
@carlossg
Copy link
Contributor

carlossg commented Jul 3, 2024

One thing that I noticed that is not going to work well. If you have devices with no power measurement that are not consuming at the time then the algorithm will overestimate how much power can be freed, then turn on the higher priority appliance just to turn it off in the next minute, and so on.
I wonder if we should be conservative and when inst.actual_power is None do not assume that power is reducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants