Skip to content

Commit

Permalink
remove testing todo
Browse files Browse the repository at this point in the history
  • Loading branch information
zuk3975 committed Jun 26, 2024
1 parent f35ac76 commit 68fb81f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
3 changes: 1 addition & 2 deletions saferpayofficial.php
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ public function hookDisplayOrderConfirmation($params)
return '';
}

//@todo: translate and move to template when requirements are clear
//@todo: order confirmation is already shown and confirmation email is already sent (altough the payment is pending), is that ok?
//@todo: translate and move to template if needed when requirements are clear
return 'Your payment is still being processed by your bank. This can take up to 5 days (120 hours). Once we receive the final status, we will notify you immediately.
Thank you for your patience!';
}
Expand Down
4 changes: 1 addition & 3 deletions src/DTO/Request/Initialize/InitializeRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ public function getAsArray()
],
'Payment' => [
'Amount' => [
//@todo: don't forget this. Its for testing/debugging. https://docs.saferpay.com/home/integration-guide/testing-and-go-live#account-to-account-payments
// 'Value' => $this->payment->getValue(),
'Value' => 4030030,
'Value' => $this->payment->getValue(),
'CurrencyCode' => $this->payment->getCurrencyCode(),
],
'OrderId' => $this->payment->getOrderReference(),
Expand Down
3 changes: 1 addition & 2 deletions src/EntityBuilder/SaferPayOrderBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@

class SaferPayOrderBuilder
{
//TODO to pass $body as InitializeBody.
public function create($body, $cartId, $customerId, $isTransaction, $status = null)
public function create($body, $cartId, $customerId, $isTransaction)
{
if (method_exists('Order', 'getIdByCartId')) {
$orderId = Order::getIdByCartId($cartId);
Expand Down

0 comments on commit 68fb81f

Please sign in to comment.