Fix issue of ignoring multiple tool calls #432
Conversation
| })), | ||
| } | ||
| } else { | ||
| output['function-call' as PortId] = { |
There was a problem hiding this comment.
The option parallelFunctionCalling switches between the function-call and function-calls output and it looks like that's lost here - this will break existing graphs, unfortunately, could you bring that behavior back?
| if (isMultiResponse) { | ||
| output['function-call' as PortId] = { | ||
| type: 'object[]', | ||
| value: functionCalls.flat().map((functionCall) => ({ |
There was a problem hiding this comment.
Are you sure that .flat() is right here? If there are multiple LLM calls that all make multiple function calls, then the output should be object[][] - an array per LLM call
There was a problem hiding this comment.
IMHO that would have the same issue as above, changing expectations. I'll leave that up to you to decide and I can make the change
There was a problem hiding this comment.
You're right, but setting the LLM to return multiple responses already arrayifies the string output, so it would make sense to arrayify the function call output as well. I consider it bug, and I doubt enough people are using multi-response with parallel function calling for it to be a big enough problem
This issue is described here: #431 (comment)