feat: disable AOT (#294)

.github/workflows/cicd.yml

@@ -12,6 +12,12 @@ on:
     types: [opened, reopened, synchronize]
   merge_group:
 
+permissions:
+  # deployments permission to deploy GitHub pages website
+  deployments: write
+  # contents permission to update benchmark contents in gh-pages branch
+  contents: write
+
 jobs:
   build-test:
     name: Build & Test
@@ -55,9 +61,32 @@ jobs:
         file: coverage.cobertura.xml
         fail_ci_if_error: true
 
-    - name: Benchmark
+    - name: Publish Benchmark
       working-directory: benchmarks/oidc-guard-benchmarks
-      run: dotnet run -c Release
+      run: dotnet publish -c Release -o bin/publish
+
+    - name: Chmod Benchmark
+      working-directory: benchmarks/oidc-guard-benchmarks/bin/publish
+      run: chmod +x oidc-guard-benchmarks
+
+    - name: Run Benchmark
+      working-directory: benchmarks/oidc-guard-benchmarks/bin/publish
+      run: ./oidc-guard-benchmarks
+
+    - name: Store benchmark result
+      if: github.ref == 'refs/heads/main'
+      uses: benchmark-action/github-action-benchmark@v1
+      with:
+        name: Benchmark.Net Benchmark
+        tool: 'benchmarkdotnet'
+        output-file-path: benchmarks/oidc-guard-benchmarks/bin/publish/BenchmarkDotNet.Artifacts/results/Sample.Benchmarks-report-full-compressed.json
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        auto-push: true
+        # Show alert with commit comment on detecting possible performance regression
+        alert-threshold: '120%'
+        comment-on-alert: true
+        fail-on-alert: false
+        alert-comment-cc-users: '@IvanJosipovic'
 
     - name: Run Trivy vulnerability scanner
       uses: aquasecurity/trivy-action@master
@@ -73,7 +102,7 @@ jobs:
     if: ${{ github.event_name != 'pull_request' }}
     name: Create Release
     runs-on: ubuntu-latest
-    needs: build-test
+    needs: [build-test]
     steps:
     - uses: actions/checkout@v4
 

NuGet.config

@@ -0,0 +1,7 @@
+<configuration>
+<packageSources>
+    <clear />
+    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
+    <add key="bdn-nightly" value="https://www.myget.org/F/benchmarkdotnet/api/v3/index.json" />
+</packageSources>
+</configuration>

benchmarks/oidc-guard-benchmarks/BenchmarkCookie.cs

@@ -1,12 +1,16 @@
 using BenchmarkDotNet.Attributes;
+using BenchmarkDotNet.Jobs;
 using FluentAssertions;
 using Microsoft.Extensions.Logging;
 using oidc_guard_tests.Infra;
 using System.Net;
 
 namespace oidc_guard_benchmarks;
 
+[JsonExporterAttribute.FullCompressed]
 [MemoryDiagnoser]
+[SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+[SimpleJob(RuntimeMoniker.NativeAot90)]
 public class BenchmarkCookie
 {
     private HttpClient client = default!;

benchmarks/oidc-guard-benchmarks/BenchmarkJWT.cs

@@ -1,12 +1,16 @@
 using BenchmarkDotNet.Attributes;
+using BenchmarkDotNet.Jobs;
 using Microsoft.Extensions.Logging;
 using Microsoft.Net.Http.Headers;
 using oidc_guard_tests.Infra;
 using System.Security.Claims;
 
 namespace oidc_guard_benchmarks;
 
+[JsonExporterAttribute.FullCompressed]
 [MemoryDiagnoser]
+[SimpleJob(RuntimeMoniker.Net90, baseline: true)]
+[SimpleJob(RuntimeMoniker.NativeAot90)]
 public class BenchmarkJWT
 {
     private HttpClient client = default!;

benchmarks/oidc-guard-benchmarks/oidc-guard-benchmarks.csproj

@@ -6,12 +6,12 @@
     <RootNamespace>oidc_guard_benchmarks</RootNamespace>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
-    <PublishSingleFile>true</PublishSingleFile>
+    <SelfContained>true</SelfContained>
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="BenchmarkDotNet" Version="0.14.0" />
+    <PackageReference Include="BenchmarkDotNet" Version="0.14.1-nightly.20240925.188" />
   </ItemGroup>
 
   <ItemGroup>

src/oidc-guard/oidc-guard.csproj

@@ -2,20 +2,22 @@
 
   <PropertyGroup>
     <TargetFramework>net9.0</TargetFramework>
-    <Nullable>enable</Nullable>
+    <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
+    <EnableRequestDelegateGenerator>true</EnableRequestDelegateGenerator>
     <ImplicitUsings>enable</ImplicitUsings>
     <InvariantGlobalization>true</InvariantGlobalization>
-    <RootNamespace>oidc_guard</RootNamespace>
-    <UserSecretsId>a70c2d04-572e-41af-8710-66bacf303453</UserSecretsId>
-    <PublishReadyToRun>true</PublishReadyToRun>
-    <EnableRequestDelegateGenerator>true</EnableRequestDelegateGenerator>
-    <EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
     <IsAotCompatible>true</IsAotCompatible>
-    <PublishAot>true</PublishAot>
     <JsonSerializerIsReflectionEnabledByDefault>false</JsonSerializerIsReflectionEnabledByDefault>
+    <Nullable>enable</Nullable>
+    <OptimizationPreference>Speed</OptimizationPreference>
+    <PublishAot>false</PublishAot>
     <PublishIISAssets>false</PublishIISAssets>
+    <PublishReadyToRun>true</PublishReadyToRun>
+    <RootNamespace>oidc_guard</RootNamespace>
+    <SelfContained>true</SelfContained>
+    <SuppressTrimAnalysisWarnings>false</SuppressTrimAnalysisWarnings>
     <TrimmerSingleWarn>false</TrimmerSingleWarn>
-    <OptimizationPreference>Speed</OptimizationPreference>
+    <UserSecretsId>a70c2d04-572e-41af-8710-66bacf303453</UserSecretsId>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Release'">

tests/oidc-guard-tests/EndToEndTraefik.cs

@@ -98,7 +98,7 @@ public async Task TokenInQuery()
         }
 
         //[Fact]
-        public async Task OIDC()
+        private async Task OIDC()
         {
             using var playwright = await Playwright.CreateAsync();
 

tests/oidc-guard-tests/Infra/MyWebApplicationFactory.cs

@@ -4,6 +4,7 @@
 using oidc_guard;
 using System.Text;
 using System.Text.Json;
+using System.Text.Json.Serialization;
 
 namespace oidc_guard_tests.Infra;
 
@@ -20,10 +21,20 @@ protected override IHost CreateHost(IHostBuilder builder)
     {
         builder.ConfigureHostConfiguration(config =>
         {
-            var data = new { Settings = settings };
+            var data = new SettingsObject { Settings = settings };
 
-            config.AddJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(JsonSerializer.Serialize(data))));
+            config.AddJsonStream(new MemoryStream(Encoding.UTF8.GetBytes(JsonSerializer.Serialize(data, typeof(SettingsObject), FactoryJsonSerializerContext.Default))));
         });
         return base.CreateHost(builder);
     }
 }
+
+public class SettingsObject
+{
+    public Settings Settings { get; set; }
+}
+
+[JsonSerializable(typeof(SettingsObject))]
+internal partial class FactoryJsonSerializerContext : JsonSerializerContext
+{
+}