Update cbsodata3.py

[ncvanegmond]

added positional arguments for functions get_table_list and _download_metadata to allow for use of proxies

[J535D165]

Thanks for this PR! Interesting feature.

A couple of remarks before merging.

1. Can you add this option for the other functions (like get_data, get_info, ... ) as well?
2. Add proxies to Options class. Add self.proxies = None here

   cbsodata/cbsodata/cbsodata3.py

   Lines 52 to 54 in a29827a

   	self.use_https = True
   	self.api_version = "3"

   Use the option manager within the functions to get the global option. See example below.

def get_info(table_id, catalog_url=None, proxies=None):
    """Get information about a table.
    Parameters
    ----------
    table_id : str
        The identifier of the table.
    catalog_url : str
        The url of the catalog. Default "opendata.cbs.nl".
    Returns
    -------
    dict
        Table information
    """

    _proxies = options.proxies if proxies is None else proxies

    info_list = _download_metadata(
        table_id,
        "TableInfos",
        catalog_url=_get_catalog_url(catalog_url),
        proxies = proxies
    )

    if len(info_list) > 0:
        return info_list[0]
    else:
        return None

Usage:

import cbsodata

cbsodata.options.proxies = "MY PROXIES"

cbsodata.get_info("82070ENG")

which is the same as

import cbsodata

cbsodata.get_info("82070ENG", proxies = "MY PROXIES")

[J535D165]

Great implementation.

The tests fail due to style errors https://travis-ci.org/J535D165/cbsodata/jobs/581151465. Thereafter, I can merge.

Would you like to have a new release on the short term?

(FYI @jolienoomens)

[ncvanegmond]

Thanks for considering the PR, and all your feedback and patience. First time making a pull requests, so figuring it out as I go :) Think I got all errors this time around.

If you would be able to do a new release on the short-term, that would be much appreciated! Very helpful library, even more so now we can use it behind a proxy ;)

[J535D165]

Thanks, merged and a new release on PyPI. Good work for your first PR!

Note. Add support for proxies in odata4 #8.