Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack stack create ctr: make specs configurable, remove warnings, add CI builds #805

Merged
merged 14 commits into from
Oct 4, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 3, 2023

Summary

Changes for how we create containers, and CI testing for them.

  1. With Update spack stack extension for containers: make specs configurable, clean up arguments for env/ctr spack#333, the spack stack create ctr command is updated, it takes four options (--container, --specs, optional --dir, optional --overwrite). This way, we don't need to manually add specs to the container recipes files, and we also get rid of annoying warnings from invalid options in the container spack.yaml.
  2. Updated the documentation with these changes.
  3. Created a CI test for container builds, because this takes so long I decided to run them on a schedule (this is UTC time, there are already nightly scheduled github actions at 2 UTC and 4 UTC for other JCSDA projects), a different container build / spec combination each day (only one spec so far --> just rotate the containers). CI can also be triggered for PRs via labels (but no choice of container or spec) or via workflow_dispatch (can choose spec, container). Because of the no-choice limitation for containers/specs for PR builds, I am not sure how valuable those are. Maybe workflow_dispatch is good enough? Keep it simple.

Testing

  • Manually built containers on the Ubuntu CI instance first
  • CI build (using docker-ubuntu-gnu-openmpi with jedi-ci)

Applications affected

JEDI CI container builds

Systems affected

None

Dependencies

Issue(s) addressed

Resolves #146

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji added INFRA JEDI Infrastructure container-ci Trigger CI tests for container builds labels Oct 3, 2023
@climbfuji climbfuji self-assigned this Oct 3, 2023
@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 3, 2023
@climbfuji climbfuji force-pushed the feature/container_env_updates branch from 4a82a36 to 23d1afa Compare October 3, 2023 17:54
@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 3, 2023
@climbfuji climbfuji force-pushed the feature/container_env_updates branch from 23d1afa to fc200ae Compare October 3, 2023 17:56
@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 3, 2023
@climbfuji climbfuji force-pushed the feature/container_env_updates branch from fc200ae to e8136f9 Compare October 3, 2023 18:08
@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 3, 2023
@@ -110,7 +109,7 @@ spack:
os: ubuntu:20.04
spack:
url: https://github.com/jcsda/spack
ref: spack-stack-1.5.0
ref: jcsda_emc_spack_stack
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An actual bug fix, this should not have been updated when spack-stack-1.5.0 was merged into develop.

@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 3, 2023
@climbfuji climbfuji marked this pull request as ready for review October 4, 2023 01:45
@climbfuji climbfuji added container-ci Trigger CI tests for container builds and removed container-ci Trigger CI tests for container builds labels Oct 4, 2023
@climbfuji climbfuji merged commit a5699ee into JCSDA:develop Oct 4, 2023
@climbfuji climbfuji deleted the feature/container_env_updates branch October 4, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container-ci Trigger CI tests for container builds INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add CI test for container build
3 participants