Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the necessary packages to build fv3-jedi using the
FV3CORE
forecast model. This includes new package definitions for:This PR also contains updates for crtm, as the Skylab v5 tag of CRTM is a bit problematic (see
crtm/package.py
for a link to the issue).Many trivial patches are needed for these packages to build outside of a bundle. These patches should all be incorporated into the JCSDA repositories. The majority of the patches are either to find the ecbuild package or to export Fortran modules properly.
I'm a bit limited in where I can run tests. The builds were tested with gcc 11.3.1 and the Intel Classic C++ compiler (oneAPI 2023.1 / icpc 2021.9.0) on Rocky Linux 9.0 using a heavily customized version of spack-stack-1.4.1. Untested on apple-clang and mainline clang, and for both the OpenMP settings might be a bit sketchy.
I would prefer that these be maintained by JCSDA instead of by me, so with Tomorrow.io's permission I am contributing these to help the broader community.
I'm opening this PR in spack instead of spack-stack because, except for crtm, these recipes are brand new and are not used in any spack-stack environments.
Issue(s) addressed
None, but @climbfuji indicates that this is part of his long term plan.
Dependencies
None
Impact
This is a step away from a UFS build of fv3-jedi in spack!
Checklist