Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fv3-jedi and its dependencies #306

Conversation

rhoneyager-tomorrow
Copy link

Description

This PR adds the necessary packages to build fv3-jedi using the FV3CORE forecast model. This includes new package definitions for:

  • GFDL_atmos_cubed_sphere
  • femps
  • fv3-jedi-linearmodel
  • fv3-jedi
  • gsw
  • ioda
  • oops
  • saber
  • ufo
  • vader

This PR also contains updates for crtm, as the Skylab v5 tag of CRTM is a bit problematic (see crtm/package.py for a link to the issue).

Many trivial patches are needed for these packages to build outside of a bundle. These patches should all be incorporated into the JCSDA repositories. The majority of the patches are either to find the ecbuild package or to export Fortran modules properly.

I'm a bit limited in where I can run tests. The builds were tested with gcc 11.3.1 and the Intel Classic C++ compiler (oneAPI 2023.1 / icpc 2021.9.0) on Rocky Linux 9.0 using a heavily customized version of spack-stack-1.4.1. Untested on apple-clang and mainline clang, and for both the OpenMP settings might be a bit sketchy.

I would prefer that these be maintained by JCSDA instead of by me, so with Tomorrow.io's permission I am contributing these to help the broader community.

I'm opening this PR in spack instead of spack-stack because, except for crtm, these recipes are brand new and are not used in any spack-stack environments.

Issue(s) addressed

None, but @climbfuji indicates that this is part of his long term plan.

Dependencies

None

Impact

This is a step away from a UFS build of fv3-jedi in spack!

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji self-requested a review August 21, 2023 15:33
@climbfuji climbfuji self-assigned this Aug 21, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Aug 21, 2023
@climbfuji
Copy link
Collaborator

Thanks a lot for contributing those @rhoneyager-tomorrow. It will take us a bit of time to work on the packages, but we'll start by fixing the style errors and checking with @BenjaminTJohnson how to best label the CRTM skylab v5 code.

@BenjaminTJohnson
Copy link

@climbfuji is this PR something that still needs attention from me?

Thanks --

@climbfuji
Copy link
Collaborator

@climbfuji is this PR something that still needs attention from me?

Thanks --

No, but thanks for asking. Unfortunately it won't make it into spack-stack-1.6.0, but I really hope that I can find a few quiet days between the years to get this updated and merged.

@rhoneyager-tomorrow rhoneyager-tomorrow changed the title Add fv3-jedi and its dependencies for Skylab v5 Add fv3-jedi and its dependencies for Skylab v5 and v6 Dec 12, 2023
@rhoneyager-tomorrow rhoneyager-tomorrow changed the title Add fv3-jedi and its dependencies for Skylab v5 and v6 Add fv3-jedi and its dependencies Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants