Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the fetchvars documentation. #713

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Expand the fetchvars documentation. #713

merged 1 commit into from
Aug 14, 2023

Conversation

kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Aug 9, 2023

Describe development

Expand fetchvars documentation as requested in #712.

Type of development

  • MINOR: some functionality is added but backward compatible

^ Just expanding upon documentation

Checklist

@kdorheim kdorheim requested a review from bpbond August 9, 2023 01:32
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Differences in Hector outputs

Hello, this is leeyabot! 🤖

The current pull request's outputs do not differ from 3.0.0 (9aebf67).

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@192c369). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head efa0767 differs from pull request most recent head e108b96. Consider uploading reports for the commit e108b96 to get more accurate results

@@          Coverage Diff           @@
##             dev     #713   +/-   ##
======================================
  Coverage       ?   79.72%           
======================================
  Files          ?       61           
  Lines          ?     5978           
  Branches       ?        0           
======================================
  Hits           ?     4766           
  Misses         ?     1212           
  Partials       ?        0           

@bpbond
Copy link
Member

bpbond commented Aug 10, 2023

Looks good!

@kdorheim kdorheim merged commit 257c18b into dev Aug 14, 2023
10 checks passed
@kdorheim kdorheim deleted the krd/doc/fetchvars branch August 14, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants