Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Telegram test chats (WIP) #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added Telegram test chats (WIP) #14

wants to merge 4 commits into from

Conversation

asaraf7
Copy link
Contributor

@asaraf7 asaraf7 commented Dec 10, 2021

No description provided.

@JRavi2
Copy link
Owner

JRavi2 commented Dec 15, 2021

@asaraf7 Apologies for the delayed response.
How exactly did you export the data? The exported data is supposed to have a format like this:

{
  "about": "...",
  "chats: {
    "about": "...",
    "list": [
      {
        "name": "Chat Name",
        "type": "Chat Type",
        "id": 12334,
        "messages": [...]
      }
    ]
}

The file that you've uploaded just has the "messages" part. In order for the program to recognize the export type, the format has to be similar to the one above.

@asaraf7
Copy link
Contributor Author

asaraf7 commented Dec 16, 2021

Yes, I have purposely kept the messages part only. If its okay, then I'll add the initial key-value pairs manually. That isn't a big deal

@JRavi2
Copy link
Owner

JRavi2 commented Dec 17, 2021

@asaraf7 Yup, the messages part looks fine for now.

@asaraf7
Copy link
Contributor Author

asaraf7 commented Jan 3, 2022

Please check now. Sorry for delay.

@JRavi2
Copy link
Owner

JRavi2 commented Jan 5, 2022

Great! Now you can add the tests in. You can use the previously added tests for WhatsApp and Signal for reference.
Let me know if you need any help with them :)

@asaraf7
Copy link
Contributor Author

asaraf7 commented Jan 6, 2022

I've added the modified Tests for Telegram. If the PR seems okay, you can merge it.

@JRavi2
Copy link
Owner

JRavi2 commented Jan 6, 2022

I think you're a bit confused about what tests are. Tests (in this case integration tests to be specific) are program(s) (tests/tests.py) that run the main program on some sample inputs (in this case the chat exports in tests/test_chats) and validate the output against the expected output.

Currently, in this PR, only the test data has been added. The actual tests which validate the output of the program are yet to be added.

@asaraf7
Copy link
Contributor Author

asaraf7 commented Jan 6, 2022

I think you're a bit confused about what tests are. Tests (in this case integration tests to be specific) are program(s) (tests/tests.py) that run the main program on some sample inputs (in this case the chat exports in tests/test_chats) and validate the output against the expected output.

Currently, in this PR, only the test data has been added. The actual tests which validate the output of the program are yet to be added.

Oh I see!
So, in tests.py there are classes for Whatsapp, and signal. And you want me to add a similar one for telegram too? Am i correct?

@JRavi2
Copy link
Owner

JRavi2 commented Jan 6, 2022

Yup, exactly!

@asaraf7
Copy link
Contributor Author

asaraf7 commented Jan 6, 2022

Yup, exactly!

Please give me some more time, since I'll have to get familiarized with some modules in your code.

@JRavi2
Copy link
Owner

JRavi2 commented Jan 6, 2022

Sure, take as much time as you need. Lemme know if you need any help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants