Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating types related to class GetOpenOfficeType #2376

Closed
wants to merge 1 commit into from
Closed

[WIP] Updating types related to class GetOpenOfficeType #2376

wants to merge 1 commit into from

Conversation

fronchetti
Copy link

@fronchetti fronchetti commented Dec 13, 2016

Hello, my name is Felipe, I am a Computer Science student and would like to contribute with JabRef.
I am trying to resolve issue #141 related to the @koppor starter repository. Could you guys take a look and tell me if I'm doing it right?

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@koppor
Copy link
Member

koppor commented Dec 13, 2016

Thank you for working on it. Please do not check in src/main/gen/. It is generated by ./gradlew generaetesources. Please fix (maybe using git commit --amend or using guit gui and use "amend"). Otherwise, the review is really hard.

Please also check the output of "Snap CI":

/var/snap-ci/repo/src/main/java/net/sf/jabref/logic/layout/format/GetOpenOfficeType.java:66: error: reached end of file while parsing
}
 ^
1 error
:compileJava FAILED

@koppor koppor changed the title Updating types related to class GetOpenOfficeType [WIP] Updating types related to class GetOpenOfficeType Dec 13, 2016
@lenhard
Copy link
Member

lenhard commented Jan 20, 2017

@fronchetti I'd like to gently ask if you plan to continue working on this PR? It's been a month since you opened the PR and you have not reacted to the comment by @koppor

@lenhard lenhard added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jan 20, 2017
@fronchetti fronchetti closed this Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants