Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colcon build error #13

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Conversation

ChanJoon
Copy link
Contributor

Error occurred on setuptools
UserWarning: Usage of dash-separated will not be supported in future versions

Change dash to underscore in setup.cfg (still not available in setuptools==64.4.0, but in 58.2.0)

Error occurs in setuptools
UserWarning: Usage of dash-separated will not be supported in future versions

Change dash to underscore (still not available in setuptools==64.4.0, use 58.2.0)
@ChanJoon
Copy link
Contributor Author

Hi, I cloned your repository and used colcon to build a package.
but there was following errors.

Starting >>> px4_offboard
/home/as06047/.local/lib/python3.8/site-packages/setuptools/dist.py:788: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/home/as06047/.local/lib/python3.8/site-packages/setuptools/dist.py:788: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
  warnings.warn(
--- stderr: px4_offboard                   
/home/as06047/.local/lib/python3.8/site-packages/setuptools/dist.py:788: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/home/as06047/.local/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
---
Finished <<< px4_offboard [3.54s]

Summary: 1 package finished [4.13s]
  1 package had stderr output: px4_offboard``

I found out that it was the problem of the version of setuptools.
After I replaced dashes to underscores and manually installed lower version of setuptools which is 58.2.0, colcon finally worked.(In the latest version, which is 64.4.0, colcon build failed due to using setup.py.)

@Jaeyoung-Lim
Copy link
Owner

@ChanJoon Thanks for the contribution.
Could you provide details on what system setup you are using?

I am a bit confused with the issue, since that part was generated through the ros2 package creator.

@ChanJoon
Copy link
Contributor Author

I'm using
OS: Ubuntu 20.04
ROS2: Foxy
Python: 3.8.10

@Jaeyoung-Lim
Copy link
Owner

@ChanJoon Hmm, okay that is odd.
I will try to add a CI for ROS foxy to reproduce this problem.

@ChanJoon
Copy link
Contributor Author

Thanks. It seems like the setup.py installation way is no more supported with the newer Python version.
there is opened issue colcon/colcon-core#454

Anyway, I'm currently learning a lot from you as an undergrad!

Copy link
Owner

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Jaeyoung-Lim Jaeyoung-Lim merged commit 15971f4 into Jaeyoung-Lim:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants