Massive Client Refactor #761
build.yml
on: pull_request
build
4m 14s
build-nix
6m 51s
Annotations
21 warnings
associated function `new` is never used:
src/modules/mod.rs#L116
warning: associated function `new` is never used
--> src/modules/mod.rs:116:8
|
115 | impl<W: IsA<Widget>> ModuleParts<W> {
| ----------------------------------- associated function in this implementation
116 | fn new(widget: W, popup: Option<ModulePopupParts>) -> Self {
| ^^^
|
constant `ERR_WAYLAND_DATA` is never used:
src/error.rs#L14
warning: constant `ERR_WAYLAND_DATA` is never used
--> src/error.rs:14:11
|
14 | pub const ERR_WAYLAND_DATA: &str = "Failed to get data for Wayland object";
| ^^^^^^^^^^^^^^^^
|
method `subscribe_outputs` is never used:
src/clients/wayland/wl_output.rs#L33
warning: method `subscribe_outputs` is never used
--> src/clients/wayland/wl_output.rs:33:12
|
23 | impl Client {
| ----------- method in this implementation
...
33 | pub fn subscribe_outputs(&self) -> broadcast::Receiver<OutputEvent> {
| ^^^^^^^^^^^^^^^^^
|
fields `output` and `event_type` are never read:
src/clients/wayland/wl_output.rs#L12
warning: fields `output` and `event_type` are never read
--> src/clients/wayland/wl_output.rs:12:5
|
11 | pub struct OutputEvent {
| ----------- fields in this struct
12 | output: OutputInfo,
| ^^^^^^
13 | event_type: OutputEventType,
| ^^^^^^^^^^
|
= note: `OutputEvent` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
fields `foreign_toplevel_manager_state`, `queue_handle`, and `loop_handle` are never read:
src/clients/wayland/mod.rs#L194
warning: fields `foreign_toplevel_manager_state`, `queue_handle`, and `loop_handle` are never read
--> src/clients/wayland/mod.rs:194:5
|
190 | pub struct Environment {
| ----------- fields in this struct
...
194 | foreign_toplevel_manager_state: ToplevelManagerState,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
195 |
196 | queue_handle: QueueHandle<Self>,
| ^^^^^^^^^^^^
197 | loop_handle: LoopHandle<'static, Self>,
| ^^^^^^^^^^^
|
= note: `Environment` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
field `output_channel` is never read:
src/clients/wayland/mod.rs#L110
warning: field `output_channel` is never read
--> src/clients/wayland/mod.rs:110:5
|
106 | pub struct Client {
| ------ field in this struct
...
110 | output_channel: BroadcastChannel<OutputEvent>,
| ^^^^^^^^^^^^^^
|
= note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
variants `OutputInfo`, `ToplevelInfo`, and `Seat` are never constructed:
src/clients/wayland/mod.rs#L84
warning: variants `OutputInfo`, `ToplevelInfo`, and `Seat` are never constructed
--> src/clients/wayland/mod.rs:84:5
|
80 | pub enum Response {
| -------- variants in this enum
...
84 | OutputInfo(Option<OutputInfo>),
| ^^^^^^^^^^
...
87 | ToplevelInfo(Option<ToplevelInfo>),
| ^^^^^^^^^^^^
...
93 | Seat(WlSeat),
| ^^^^
|
= note: `Response` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
variable does not need to be mutable:
src/main.rs#L236
warning: variable does not need to be mutable
--> src/main.rs:236:9
|
236 | let mut config = env::var("IRONBAR_CONFIG")
| ----^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
unused variable: `seat`:
src/clients/wayland/wl_seat.rs#L54
warning: unused variable: `seat`
--> src/clients/wayland/wl_seat.rs:54:9
|
54 | seat: WlSeat,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_seat`
|
unused variable: `seat`:
src/clients/wayland/wl_seat.rs#L27
warning: unused variable: `seat`
--> src/clients/wayland/wl_seat.rs:27:9
|
27 | seat: WlSeat,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_seat`
|
unused variable: `qh`:
src/clients/wayland/wl_seat.rs#L26
warning: unused variable: `qh`
--> src/clients/wayland/wl_seat.rs:26:9
|
26 | qh: &QueueHandle<Self>,
| ^^ help: if this is intentional, prefix it with an underscore: `_qh`
|
= note: `#[warn(unused_variables)]` on by default
|
method `subscribe_outputs` is never used:
src/clients/wayland/wl_output.rs#L33
warning: method `subscribe_outputs` is never used
--> src/clients/wayland/wl_output.rs:33:12
|
23 | impl Client {
| ----------- method in this implementation
...
33 | pub fn subscribe_outputs(&self) -> broadcast::Receiver<OutputEvent> {
| ^^^^^^^^^^^^^^^^^
|
fields `output` and `event_type` are never read:
src/clients/wayland/wl_output.rs#L12
warning: fields `output` and `event_type` are never read
--> src/clients/wayland/wl_output.rs:12:5
|
11 | pub struct OutputEvent {
| ----------- fields in this struct
12 | output: OutputInfo,
| ^^^^^^
13 | event_type: OutputEventType,
| ^^^^^^^^^^
|
= note: `OutputEvent` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
|
field `foreign_toplevel_manager_state` is never read:
src/clients/wayland/mod.rs#L194
warning: field `foreign_toplevel_manager_state` is never read
--> src/clients/wayland/mod.rs:194:5
|
190 | pub struct Environment {
| ----------- field in this struct
...
194 | foreign_toplevel_manager_state: ToplevelManagerState,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `Environment` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
field `output_channel` is never read:
src/clients/wayland/mod.rs#L110
warning: field `output_channel` is never read
--> src/clients/wayland/mod.rs:110:5
|
106 | pub struct Client {
| ------ field in this struct
...
110 | output_channel: BroadcastChannel<OutputEvent>,
| ^^^^^^^^^^^^^^
|
= note: `Client` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
variants `OutputInfo`, `ToplevelInfo`, and `Seat` are never constructed:
src/clients/wayland/mod.rs#L84
warning: variants `OutputInfo`, `ToplevelInfo`, and `Seat` are never constructed
--> src/clients/wayland/mod.rs:84:5
|
80 | pub enum Response {
| -------- variants in this enum
...
84 | OutputInfo(Option<OutputInfo>),
| ^^^^^^^^^^
...
87 | ToplevelInfo(Option<ToplevelInfo>),
| ^^^^^^^^^^^^
...
93 | Seat(WlSeat),
| ^^^^
|
= note: `Response` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|